Advanced user form display not themed: theme_advuser_admin_account(&$form) [#1148604]

Great work on this module. I have been using v2.3 for a while on a bunch of sites.

Short story:
- Problem: advuser/forms/advuser_admin_account.inc -> theme_advuser_admin_account(&$form)
- Fix: change theme_advuser_admin_account(&$form) to theme_advuser_admin_account($form)

Long story:
- Using 2.3 version on dev site
- Disabled module
- Deleted module files
- Installed latest 6.x-3.x-dev using GIT
- Enabled module
- Browsed to <>/admin/user/user/advuser
- User data was being displayed wrong. All usernames displayed in one line followed by all user's emails on one line etc
- Thought it was leftover settings from 2.3
- Executed all uninstall code from 2.3
- Reinstalled 3.x module using devel
- Problem still persisted
- Checked theme_advuser_admin_account() and it looked good
- Added debug message to function and noticed it was not executing
- Realized $form was being passed by reference: &$form

Comment	File	Size	Author
#1	advuser_theme-1148604-1.patch	487 bytes	tinker

Comments

Comment #1

tinker commented 5 May 2011 at 22:34

Status	File	Size
new	advuser_theme-1148604-1.patch	487 bytes

Attached patch

Comment #2

Anonymous (not verified) commented 13 May 2011 at 16:03

Status:

Needs review

» Reviewed & tested by the community

I guess this is going to have to do. I was thinking that the call by ref would fill the $form with the new data I set in it for later use. But it shouldn't matter.