We have code to support legacy hook_services this should be removed.

CommentFileSizeAuthor
remove-legacy-code.patch1.52 KBmarcingy

Comments

kylebrowning’s picture

kylebrowning commented

Looks fine to me, no time to commit today though, feel free to do so yourself.

ygerasimov’s picture

ygerasimov commented
Status: Needs review » Reviewed & tested by the community

I also believe this patch is OK to be committed.

ygerasimov’s picture

ygerasimov commented
Status: Reviewed & tested by the community » Needs work

Btw I have found function _rest_server_autoload_info in rest_server.inc. As I understand it was implementation of hook_autoload_info for drupal 6 but it is no more needed for 7.x-3.x

Can we remove this file completely?

marcingy’s picture

marcingy commented
Status: Needs work » Reviewed & tested by the community

Can we do this in small steps rather than killing kittens, the second issue can be follow up. Back to RBTC on those grounds.

ygerasimov’s picture

ygerasimov commented

Yes, small steps sounds reasonable. Please commit patch above and we can create other issues to remove other chunks.

mrfelton’s picture

mrfelton commented
Status: Reviewed & tested by the community » Needs work

What about the services_update_6001() and services_update_6002() in services.install? Those aren't needed are they? They cause problems with Aegir. I cant upgrade a site from a Drupal 7.4 platform to 7.7 because Aegir thinks that the version of services on the 7.7 platform is version 6002 - which clearly it isn't. I'm guessing its reading this from the .install file, as that is the only place 6002 is mentioned.

marcingy’s picture

marcingy commented
Status: Needs work » Reviewed & tested by the community

See comment above...that is a seperate issue and will be dealt with as such, putting back to be RBTC.

marcingy’s picture

marcingy commented

New issue created http://drupal.org/node/1232688 - patch welcome :)

marcingy’s picture

marcingy commented
Title: Remove old legacy code » Remove _services_legacy_services_as_resources code
kylebrowning’s picture

kylebrowning commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.