Hi

Htmltidy is a really nice module having code indentation, format html and other features. I am Using this for one of my D7 project So here I have created a patch for it. I test it on few nodes, it worked for me, Please review this and give feedback.

Thanks

regards
Dev/Kuldev

CommentFileSizeAuthor
htmltidy-6.x-1.4.patch36.16 KBdevtherock

Comments

michaelfavia’s picture

michaelfavia commented
Status: Active » Fixed

Thanks bud. Your work is very appreciated. Added: http://drupal.org/node/1149242 . Will test more officially when i have a moment.

devtherock’s picture

devtherock commented

Thank you Michael.

Gabrieles’s picture

Gabrieles commented

Thank you, great to see HTMLtidy ready for D7!

One small issue: it throws out an annoying "Deprecated function: Function split() is deprecated in htmltidy_run() (line 645 of /var/www/goldrake/sites/all/modules/htmltidy/htmltidy.module)."

According to http://www.phpfreaks.com/forums/index.php?topic=272011.0 I edited htmltidy.module and substituted (twice) the "split()" function with "explode()" and the warning disappeared - any drawbacks in this?

devtherock’s picture

devtherock commented

Thanks you very much friend, patch created in hurry (and this was my first patch contributed to community :) ) so there can be issue left which I didn't see.

Thanks

regards
Dev/Kuldev

michaelfavia’s picture

michaelfavia commented

If you'd like to provide a patch for the changes you made and attach it ill be happy to commit it for you. Patching isnt very difficult if you have git installed on your machine. Just perform a "git diff" once you have checked out the most recent dev branch using:

git clone --branch 7.x-1.x http://git.drupal.org/project/htmltidy.git
cd htmltidy

More instructions here http://drupal.org/documentation/git if you need help with git itself. Its pretty straightforward and its always nice to give back if you have a minute to learn how. Thanks for participating regardless and good luck.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tlangston’s picture

tlangston commented

why is there not a D7 release of this module?

michaelfavia’s picture

michaelfavia commented

TO be honest i havent really had the time to maintain it as i dont use it anymore. I just enabled the dev snapshot for you. drupal.org should build it in the next 12 hours. If you test it and report back any issues ill happily roll a release and credit you.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented
Version: 6.x-1.4 » 7.x-1.x-dev

For future reference, this was committed in 6718f6b.

tlangston’s picture

tlangston commented

Thanks guys - works great!