if a field throws a validation error there is no hint which one this was.

CommentFileSizeAuthor
#2 0001-fixed-1149274-error-should-mention-which-field-it-co.patch1.33 KBgeek-merlin
#1 0002-fixed-1149274-error-should-mention-which-field-it-co.patch1.34 KBgeek-merlin

Comments

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Title: validation errors do not mention which field » validation errors should tell which field they come from
Status: Active » Needs review
StatusFileSize
new 0002-fixed-1149274-error-should-mention-which-field-it-co.patch1.34 KB

now they do!

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
StatusFileSize
new 0001-fixed-1149274-error-should-mention-which-field-it-co.patch1.33 KB

forget this las patch, we really should sanitize / t() the error message or the security police will shut down this module ;-)

this is better.

g089h515r806’s picture

g089h515r806 commented

t() is used for interface text. not for dynamic text.

$rule['error_message'] is dynamic, it is entered by administrator, we do not need to use t() here.

webform_validation does not use t() here, i just follow its way.

g089h515r806’s picture

g089h515r806 commented

i have add t() for error message in beta1 version.
Thanks

g089h515r806’s picture

g089h515r806 commented
Version: 7.x-1.0-alpha1 » 7.x-2.x-dev
Status: Needs review » Fixed

We support basic tokens in 7.x-2.x, it could solve this issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.