This is a theme I have created for websites for my skier friends and brother and sister. You can view a working site running this theme at http://rhymeswithbrake.com/.

It's is built on the HTML5 Boilerplate (the version's from around Dec 2010). It's a fixed layout, based on three 290px columns with 10px space between them. The main content is two columns and there is a right sidebar that is one column. There are seven main navigation links up top (at least there's space for seven). I use Home, Bio, Blog, Videos, Results, Sponsors and Contact. Above the right sidebar there is a twitter feed. The handle can be customized in the settings of the theme. There is a two column wide featured video on the home page that can be customized in the theme's settings.

This theme provides support for a custom content type "video". This should have a text field of "field_video_url", a list option field of "field_video_host" with the options "youtube", "vimeo" and "facebook" and a long text field of "field_description".

There are several things I'm planning on doing with this theme.

Link to a backup and migrate restore file to add the custom content type, custom views, custom block settings and other settings that I use.

Simplify the video content type so you don't have to select a video host.

User customizable background image.

The project page is at http://drupal.org/sandbox/apexskier/1149402

CommentFileSizeAuthor
screenshot-page.png1.02 MBCameron Little
screenshot-front.png923.53 KBCameron Little

Comments

sreynen’s picture

sreynen commented
Issue tags: +PAReview: Theme

Adding a tag for theme reviews.

mariagwyn’s picture

mariagwyn commented
Issue tags: -PAReview: Theme +PAReview: Theme pdx-code-review
sarah_p’s picture

sarah_p commented
Component: new project application » theme
mariagwyn’s picture

mariagwyn commented

The PDX user group just reviewed your theme. It looks fun, and below are some specific recommendations. The most significant is to clarify in your description and a readme file what the purpose of your theme is, its unique video feature, and how to set it up.

  1. JS licensing issues. Modernizr/dd_belated is MIT license. Must be GPL 2.0 or later. If you can't include it, give install instructions.
    node--video
    1. template may need to be renamed to node-video.
    2. this tpl file mixes logic with presentation. They should be separate. See: http://drupal.org/node/1965. At first glance, it is unclear what this page is for and if it requires the creation of a node type, if it is related to the function "settings[featured_video]" in info file. Perhaps a README to clarify this relationship?
  2. By loading video structure into the page.tpl file, you are presetting the front page. This is an intriguing idea, and may work well. However, you need to clarify that this is what the theme is going to do and how to set it up. Be sure to explain somewhere how to modify the info file to put your video url.
  3. If your node.tpl file is no different than the default tpl file, you don't need to have it in your theme. Drupal will automatically add missing tpl files. Only add a tpl file if it has something unique, or a tpl file is dependent on it (such as node--video which requires node.tpl). I.e., you might not need page.tpl.php & comment.tpl, etc. unless it has unique structure.
  4. Your CSS is written for HTML. tags such as article, footer will be passed over by non-compliant browsers. Not a biggie since you don't have much dependent on it, but just a note.
mariagwyn’s picture

mariagwyn commented
Status: Needs review » Needs work

tagging: needs work

Cameron Little’s picture

Cameron Little commented

Thanks a lot for your comments. I'll review it when I have time and make those changes. I actually am not using Modernizr, I'll just need to take it out.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Closed (won't fix)

Closing, feel free to re-open if this was a mistake.