Could not restore backup and rollback from failed upgrade [#1149454]

Here's the situation: both modules and core need updates, run drush upc and update the modules but select 'n' when given the option to update core. Drush will try and rollback changes to the modules (backup->rollback()) but the destination directories exist (the module updates were successful) and Drush raises the above error.

The attached patch forces the directory move and clears up the error. However, it makes it difficult to update modules without updating core -- which is essentially what currently happens. The ideal solution would be to offer a --no-core option to pm-updatecode. I'll work on that next...

Comment	File	Size	Author
#4	drush-1149454.patch	2.81 KB	jonhattan
#3	1149454-no-core2.patch	2.81 KB	mikeker
#1	1149454-no-core.patch	2.48 KB	mikeker
	force-overwrite-on-rollback.patch	800 bytes	mikeker

Comments

Comment #1

mikeker commented 6 May 2011 at 19:24

Status	File	Size
new	1149454-no-core.patch	2.48 KB

Here's one that adds a --no-core option to pm-updatecode. This gives us the current functionality (update modules only) without the error messages.

Comment #2

greg.1.anderson commented 6 May 2011 at 19:31

Code looks good. I think this is the best option for correcting this situation (compared, say, to subverting the rollback during abort in one way or another).

Perhaps could use an extra message if user aborts the upgrade of core and causes a rollback ("run again with --no-core to upgrade modules only"). A little annoying, but again, alternatives can potentially be worse.