Links with spaces are not validated / add link failed

+1

Is one of You guys able to fix the regexes in _linkchecker_extract_links() and provide patch, please? This should be a D6 bug only.

Function valid_url() returns FALSE for links with spaces... http://www.example.com/foo%20bar/foo works. Not sure how we can fix this.

drupal_encode_path() rawencode double points, ankers, question marks and others. url() does not work, too.

This may work, but I expect more than only spaces and side effects... damn hacks... I hate them. Current design may be wrong.

Line 1356 ff:

  $links = array();
  foreach ($urls as $url) {
    // Full qualified URLs.
    // HACK: Encode spaces in URLs; validation equals TRUE; Link gets added.
    if (valid_url(str_replace(' ', '%20', $url), TRUE)) {
      $links[] = $url;
    }
    // Skip mailto:, javascript:, etc.
    elseif (preg_match('/^\w[\w.+]*:/', $url)) {
      continue;
    }

Funny, drupal_http_request() can request URLs with spaces...

Decided to go with the hack for now.

Hi,

Not sure whether to reopen this issue, or refer to the similar D6 issue #1525146: Space in filename triggers 404. But although links with spaces in them are added to the report now, the linkcheck itself seems to return an incorrect 404 if the link contains a space.

Still experiencing the problem reported by drupal_jon: files with a space in them incorrectly appear in the link report as 404, even though the link works. You can click on one of the 404 links in the link report and it successfully loads the page.

Actually, this is a content problem. Drupal's valid_url() function correctly returns FALSE if the URL has a space in it. The URLs in the content should use %20 instead of a space, even though most browsers handle a space without issue.