Create an 'add skin configuration' form to edit any element on the site

Using contextual links would have been nicer, but unfortunately that's not possible. According to @moonray there is no context:

So we have no idea which view or panel we are trying to add a link for at that point.

Views' contextual links get attached to the page hook. That means context is all off. Luckily they add some context, which is what I can pick up. But it's not really the element you expect it on. That's what threw me off initially.

Panels... that is a completely different cup of tea. Getting to that through hook_panels_pane_content_alter().

Given that, I think this patch is ok once all of the functions are documented and the validation portion is added.

Err, yeah. I meant hook_contextual_links_view_alter()

Frankly, I'm not convinced that this patch is the right thing to do at this point in time. It adds a lot of custom and module-specific logic to Skinr -- whereas I actually hoped that our intention would be to decrease the amount of custom code.

It is definitely going to hinder progress on the further API changes that we need to do.

That's not to say this patch or idea would be entirely wrong, but for me it feels like trying to stick a piece of fancy on an ugly pig.

+++ modules/block.skinr.inc
@@ -30,30 +30,43 @@ function block_skinr_config_info() {
+    $blocks = _block_rehash($theme);

RED WARNING LIGHTS AND ALARM BELLS should trigger here.

_block_rehash() is not only not cached, but additionally, it's purpose is to rebuild and update the {block} DB table.

Powered by Dreditor.

Frankly, I'm not convinced that this patch is the right thing to do at this point in time. It adds a lot of custom and module-specific logic to Skinr -- whereas I actually hoped that our intention would be to decrease the amount of custom code.

It is definitely going to hinder progress on the further API changes that we need to do.

@sun do you see an alternative way of accomplishing it? This particular issue has been a problem for over a year, even with Drupal 6 before using contextual links. If you have any suggestions, they'd be appreciated. :)

We need this working though, so we can't wait around for perfection.

Tested the patch in #6 as working with general skins and panels, but I didn't extensively tests panel usage, just creating a panel page and using a skin there. I didn't try using mini panels since you said it still needs integrating.

Trying to add a view was initially giving me a fatal error until I updated the views module, then it was fine. Is there anything else I should try and look for/test here?

Subscribing