I think there's a way I can allow through-the-web editing of template files.

  1. The htmlmail_install() function would need to create a files/htmlmail_templates folder for storing template files.

  2. The htmlmail_theme() function would need to scan the newly-created folder, in addition to the theme folder and the module folder, for template files.

  3. A templates tab needs to be added to the module settings page.

  4. The htmlmail_update_7000() function would need to create a template file for each existing 1.x template variable.

  5. All of the above would need to be backported to the 6.x-2.x branch

CommentFileSizeAuthor
#18 allow-through-web-editing-1150140-17.patch17.68 KBroam2345
#17 allow-through-web-editing-1150140-16.patch16.35 KBroam2345
#16 allow-through-web-editing-1150140-15.patch15.88 KBroam2345
#14 allow-through-web-editing-1150140-14.patch16.39 KBroam2345
#13 allow-through-web-editing-1150140-13.patch16.3 KBroam2345
#12 allow-through-web-editing-1150140-12.patch15.45 KBroam2345
#11 allow-through-web-editing-1150140-11.patch387 bytesroam2345
#10 allow-through-web-editing-1150140-10.patch15.66 KBroam2345

Comments

ekirchhoff’s picture

ekirchhoff commented

Love to see this happen

pillarsdotnet’s picture

pillarsdotnet commented

Cool. That's one. Anybody else?

fuquam’s picture

fuquam commented

Yeah that would be sweet. I don't intend on going to D7 soon so if it worked in D6 as well . . .

pillarsdotnet’s picture

pillarsdotnet commented

See #5 in OP

fuquam’s picture

fuquam commented

Sorry I got too excited at #3 and stopped reading :)

Seph’s picture

Seph commented

Sounds awesome!

Vasu’s picture

Vasu commented

Any progress on this ...............! I hope this feature will bring back the simplicity offered by this modules in earlier versions and also improve the usage (I see a plateau in overall statistics). When I first saw the module in 6x I jumped and installed because of the simple interface. Now despite 9 moths after drupal 7 release I am still thinking whether to install this or not ('cause I am using the default 'bartik' theme, I need to copy the template file each time I upgrade drupal- which is happening very frequently).

pillarsdotnet’s picture

pillarsdotnet commented

Any progress on this

Just an idea at the moment. I've been rather immersed in another project and haven't had as much time to spend on HTML Mail lately, but will have to get back to it soon.

Part of the reason I posted this issue was to gauge the interest by counting responses.

mrfelton’s picture

mrfelton commented
Status: Needs work » Active
roam2345’s picture

roam2345 commented
Issue summary: View changes
StatusFileSize
new allow-through-web-editing-1150140-10.patch15.66 KB

Still missing a way to delete the newly created templates, but here is an initial patch.

roam2345’s picture

roam2345 commented
StatusFileSize
new allow-through-web-editing-1150140-11.patch387 bytes

With delete working and missing tab fixed.

roam2345’s picture

roam2345 commented
Status: Active » Needs review
StatusFileSize
new allow-through-web-editing-1150140-12.patch15.45 KB

my bad did not check last patch, here its fixed.

roam2345’s picture

roam2345 commented
StatusFileSize
new allow-through-web-editing-1150140-13.patch16.3 KB

Adjust the lookup path of the new templates.

roam2345’s picture

roam2345 commented
StatusFileSize
new allow-through-web-editing-1150140-14.patch16.39 KB

Rather overwrite the theme items, this is cleaner.

roam2345’s picture

roam2345 commented
roam2345’s picture

roam2345 commented
StatusFileSize
new allow-through-web-editing-1150140-15.patch15.88 KB

We use pantheon and the change the $_SERVER['DOCUMENT_ROOT'] variable in hence we need another way of determining the relative path.

roam2345’s picture

roam2345 commented
StatusFileSize
new allow-through-web-editing-1150140-16.patch16.35 KB

Last one, pervious patch had issues still on pantheon.

roam2345’s picture

roam2345 commented
StatusFileSize
new allow-through-web-editing-1150140-17.patch17.68 KB

some last clean up working beautifully for us.

neoxavier’s picture

neoxavier commented

can we make it to work with features/strongarm?

Utkarsh_Mishra’s picture

Utkarsh_Mishra commented
Status: Needs review » Reviewed & tested by the community

The last submitted patch, 17: allow-through-web-editing-1150140-16.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

The last submitted patch, 14: allow-through-web-editing-1150140-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

salvis’s picture

salvis
he/his
commented
Assigned: pillarsdotnet » Unassigned
Status: Reviewed & tested by the community » Needs review

What exactly are we trying to do here, and what kind of reviewing and testing did you do?

Utkarsh_Mishra’s picture

Utkarsh_Mishra commented

I tried applying patch and it was applied successfully and then i sent the mail it worked fine so i RTBC it, sorry if i didn't understand it correctly.

salvis’s picture

salvis
he/his
commented

This issue is very old, and I need someone to explain to me what it's all about. What is the purpose of this issue / patch?

I tried applying patch and it was applied successfully and then i sent the mail it worked fine

What is it that did not work before you applied the patch, and worked fine after you applied the patch?

tr’s picture

tr commented
Version: 7.x-2.x-dev » 8.x-3.x-dev
Status: Needs review » Needs work

New features should be added to the current version 8.x-3.x first, then be backported only if there is interest from the community.