Upgrade the cod_base Feature to D7. This feature needs to be upgraded before any of the other seven Features.

Comments

senpai’s picture

Priority: Normal » Major

switching to 'major' so we can find them in the queue.

senpai’s picture

Component: Code » cod_base

switching from 'code' to 'cod_base'.

sirkitree’s picture

Assigned: Unassigned » sirkitree

I'm working on this - couple notes:

* admin_toolbar is in strongarm, need to make this a dependency
* Profile fields are shared across a couple contexts in other features so do belong in here
* holding off on the UUID pieces of this (menu item and a node) until #1103674: Initial Port of UUID Features to Drupal 7 is committed

sirkitree’s picture

StatusFileSize
new30.38 KB

Here's the first stab at this. With some of the other features not ready, I did not include the custom menu exports, that should come once the modules that provide those actual URI's become available.

Items included in this patch that are in the d6 version:

dependencies[] = "admin"
dependencies[] = "features"
dependencies[] = "strongarm"
dependencies[] = "views"
features[ctools][] = "strongarm:strongarm:1"
features[field][] = "user-user-field_profile_first"
features[field][] = "user-user-field_profile_interests"
features[field][] = "user-user-field_profile_job_title"
features[field][] = "user-user-field_profile_last"
features[field][] = "user-user-field_profile_org"
features[user_permission][] = "access administration pages"
features[user_permission][] = "access site reports"
features[user_permission][] = "administer permissions"
features[user_permission][] = "administer site configuration"
features[user_permission][] = "administer users"
features[user_permission][] = "administer views"
features[user_permission][] = "use admin toolbar"
features[user_role][] = "site administrator"
features[variable][] = "admin_toolbar"

Items it does not currently contain:

features[menu_custom][] = "menu-conference-admin"
features[menu_custom][] = "menu-quick-links"
features[menu_links][] = "menu-conference-admin:79f090a8-755e-102e-a8fe-4040db1cdced"
features[menu_links][] = "menu-conference-admin:admin/build/features"
features[uuid_node][] = "79f090a8-755e-102e-a8fe-4040db1cdced"
sirkitree’s picture

Status: Active » Needs review
mariagwyn’s picture

I am interested in testing this as necessary. does "needs review" mean that I can run a patch on a d6 version of cod_base, and activate the patched feature on d7? is it really at that stage or should I wait a bit?

I have never participated in testing, but I want these features for d7 so if I can help I will.

paulgemini’s picture

subing

ezra-g’s picture

I re-rolled and made some slight tweaks and committed this along with some related updates to cod_session. Still not properly exported here are all the UUID components, but this is a huge step forward.

Thanks, sirkitree!

http://drupalcode.org/project/cod_support.git/commit/2f4cfea
http://drupalcode.org/project/cod_support.git/commit/299fbc7

ezra-g’s picture

Also, I apologize for not remembering to use the --author flag in those commits - Will do so in the future!

ezra-g’s picture

Also not updated is the full name field formatter. I should take some time to update the issue summary now that that's possible :).

rupl’s picture

StatusFileSize
new2.77 KB

Here is a first pass at D7 full name field formatter. Patch was based off of 7.x-1.x of cod_support. For testing I used single and multi-value Speaker(s) within the Session content type.

rupl’s picture

StatusFileSize
new3.64 KB

I forgot to swap out language constants after debugging. New patch.

rgon’s picture

This patch applies using the patch command but doesn't seem to apply using git apply. Git apply doesn't change anything but also provides no output. To confirm that the patch works, would I need to have sessions working to check for the output of the field? If this field formatter is only intended for session nodes, then would it be best to included the code in the cod_sessions feature?

tommyk’s picture

As part of the LA Drupal code sprint I attempted to enable the COD Base feature on a fresh site without doing anything else. My codebase was a clone of the master from http://drupal.org/sandbox/christefano/1300774. The database was empty, and I installed the 'cod' profile, which seems a bit broken itself because hardly any modules were enabled.

The COD Base feature was overridden immediately upon being enabled, which seems like a problem.

Steps to reproduce:

1. install with cod profile from above codebase
2. enable COD Base feature
3. enable dependencies
4. drush dl diff and drush en diff to see overrides
5. review overrides for COD Base feature
6. code references a 'session organizer' role that has not been created on the site
7. line 78 of cod_base.features.user_permission.inc is this part of the code
8. 'session organizer' should probably be included with 'site administrator' role that is included in cod_base.features.user_role.inc

also, warning at the top of the review overrides page says "Notice: Undefined property: stdClass::$in_code_only in variable_features_export() (line 158 of …/profiles/cod/modules/contrib/strongarm/strongarm.module)."

The fix for this might be as simple as adding the 'session organizer' role to the feature, but I wanted to give others an opportunity to investigate as well.

mrconnerton’s picture

Codesprinting at Sandcamp:

I have downloaded drupal 7-10 then did a git clone of cod_support. I then applied the patch in #12. After turning on base I also got an overridden state because of the missing role, but that role is exported to cod_session so not a terrible issue at the moment.

I did a compare of the cod_base modules exports with the d6 version. There are menu/links missing but that was expected per #4

There are a few vars missing:

configurable_timezones
signup_ignore_default_fields
site_footer
theme_settings

And there was a permission "view own orders" from ubercart that is not in there which can be replaced with whatever the commerce equivalent is.

ezra-g’s picture

Status: Needs review » Fixed

I did some testing and:

- Committed the full name formatter from #12 - Thanks, rupl! http://drupalcode.org/project/cod_support.git/commit/3966950
- Removed references to the missing COD Session role per #14 and 15 - Thanks! http://drupalcode.org/project/cod_support.git/commit/0d4f651

Let's continue working in new followup issues. I filed #1441672: D7: Restore COD Base Conference admin menu links for the missing conference admin menu links.

Thanks, everyone!!!!!

Automatically closed -- issue fixed for 2 weeks with no activity.