I should probably first apologise for being totally new to Drupal.

I simply want to know if receiving the following strict warning on a fresh drupal 7 install is ok. The warning comes when I try to add a new custom layout by going custom layout>add flexible layout.

Strict warning: Creating default object from empty value in panels_layouts_ui->edit_form() (line 72 of C:\xampp\htdocs\sites\all\modules\panels\plugins\export_ui\panels_layouts_ui.class.php).

I should say that despite the warning, it does all work fine - it just seems an early stage in the process to be getting such a warning.

The modules I have installed are all the preconfigured core modules, Chaos Tool Suite (Chaos Tools only), Panels (Panels and Panel nodes only) and Views (Views and Views UI only).

Thanks for any pointers you may have.

CommentFileSizeAuthor
#4 panels-1150496-4-D6.patch1.16 KBmikeytown2
#2 panels_layout_ui_strict_warning-1150496-2.patch648 byteslifepillar

Comments

lifepillar’s picture

lifepillar commented
Category: support » bug

Turning this into a bug report, as this is definitely a (maybe minor) bug. The problem is that the $display variable is not initialized at that point.

lifepillar’s picture

lifepillar commented
Status: Active » Needs review
StatusFileSize
new panels_layout_ui_strict_warning-1150496-2.patch648 bytes

The enclosed patch may be a proper fix.

mikeytown2’s picture

mikeytown2 commented

Patch works for 6.x; please apply to both branches.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new panels-1150496-4-D6.patch1.16 KB

Found another error Strict warning: Creating default object from empty value in panels_renderer_standard->render_pane_content(); patch is for 6.x & fixes it.

Ingmar’s picture

Ingmar commented

Is it also applicable for 7.x?

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

This is not the proper fix. Follow the code:

      $display->cache_key = $cache_key;
      panels_cache_clear('display', $cache_key);
      $cache = new stdClass();

      $display = panels_new_display();

That notice actually is telling us about a real bug. The cache_key is getting set and then immediately wiped. We simply need to move that call down. Not mask that it's an error.

We don't even need to move it down -- a bit later, it's set again. That line can simply be deleted. Committed and pushed that.

The other problem is fixed in #1241064: In panels_renderer_standard::render_pane_content(), the return value of ctools_content_render() should be cast to an object..

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit e4952ef on 7.x-3.x, 7.x-3.x-i18n, 8.x-3.x by merlinofchaos: 
    Issue #1150496: Fix strict notice with wrong set to display->cache_key