Hiya,

Great module. Just wondering if it's difficult to remove the company name from the module and function names?

I thought it was part of the Drupal policythat company names (or abbreviations) weren't allowed in contributed modules.

Phil

Comments

LeeMcL’s picture

LeeMcL commented
Assigned: Unassigned » LeeMcL
Status: Active » Closed (works as designed)

They are my initials (Lee McLoughlin) not the companies. They are there mostly to differentiate my module from the original paypal module.

Lee

Phillip Mc’s picture

Phillip Mc commented
Status: Closed (works as designed) » Active

LMMR Tech is in the modules I have...

"Welcome to the LMMR Tech PayPal modules for Drupal"

$lm = l('LMMR Tech', 'http://lmmrtech.com');

It's not a big thing, but, if contributers all started inserting adverts like that into their modules, it would sort of put me off using their modules.

That's more like freeware...not open source?

And I wonder if that will put off others spending work-hours contributing and offering patches.. or do you envisage a "welcome to the [insert long list of company names] paypal modules for Drupal"?

anyway. I think I can remove the advert and search and replace the lm_ prefix string to something more intuitive.

Are there any other adverts in the module that users should know about or is it just the ""Welcome to the LMMR Tech PayPal modules for Drupal" one?

phil

LeeMcL’s picture

LeeMcL commented
Status: Active » Closed (works as designed)

Ahh... I see what you mean. When you said "company name from the module and function names" I thought you just meant the leading "lm_". I do see your point about the list of company names in the welcome message maybe growing longer in time... I'll change the welcome to just be '... the alternative PayPal module ...'

I don't think my function/module naming scheme is breaking any Drupal rules/suggestions/codes of practices... So I think it best things stay as they are. But if I've missed a Drupal rule/... then please send me a pointer to it!

Lee