As per issue #1150988: Block for search filters based on custom fields displaying field keys instead of labels, it would make a more robust API to allow for options to be passed the the map callback.

CommentFileSizeAuthor
#3 1151086-map-options-3.patch1.58 KBpwolanin
#2 1151086-map-options-2.patch1.56 KBpwolanin
#1 facetapi-1151086-1.patch1.67 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new facetapi-1151086-1.patch1.67 KB

The attached patch adds the functionality.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1151086-map-options-2.patch1.56 KB

I came up with nearly the same myself, but not using call_user_func_array() which is a bit slower than directly invoking with the params.

pwolanin’s picture

pwolanin commented
StatusFileSize
new 1151086-map-options-3.patch1.58 KB

Actually, for consistency, we should use call_user_func() both places, which allows then the callback to be an array specifying a class or instance + method.

cpliakas’s picture

cpliakas commented
Status: Needs review » Reviewed & tested by the community

#3 looks good to me. Commit when ready.

pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Fixed

committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.