Posted by superfedya on May 9, 2011 at 4:51pm
19 followers
| Project: | CDN |
| Version: | 6.x-2.x-dev |
| Component: | Miscellaneous |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Hello,
Can somebody provide me a patch for the last DEV. version of ImageCache? Because there some lines is different than in beta10.
Thank you
Comments
#1
In 6.x-2.0-beta12 #570132: Support CDN rewriting of ImageCache paths has been applied.
#2
I just updated imagecache to 6.x-2.0-beta12 and status report page says I don't have patch applied. Below is entire message:
CDN — ImageCache patch Not/incompletely applied patch or updated patch.
This patch has not been properly applied to the following files (or the patch has been updated):
/public_html/sites/all/modules/imagecache/imagecache.module
Please consult the installation instructions in the included README.txt.
I'm using latest Pressflow.
#3
Same thing it's happening to me. It seems that CDN is trying to find exactly the patch in the imagecache.module, but the patch is already applied.
#4
I updated to the new version of imagecache module 6.x-2.0-beta12 and I lost the imagecache patch it is not applied any more and I cannot apply the old one again, when I enable the cdn to use the imagecache to produce the presets it produces the old presets but not the new presets.
#5
I am using drupal 6.20
#6
I get the same problem
" This patch has not been properly applied to the following files (or the patch has been updated) ".
Same results for both the dev and 2.1 versions. Any suggestions anyone? Thanks.
#7
Marked #1165076: Applying Inagecache Patch for latest version 6.x-2.0 Beta 12 Results in Error as a duplicate of this.
There's a patch on #1064912: Provide internal setting to stop CDN from verifying the ImageCache patch that'll have it stop complaining.
#8
@drewish
Am I mistaken, is this patch for someone who does not want to use a cdn to serve imagecache actions?
Basically shut off the verificaton of the patch?
Cause I want to use that latest version of imagecache beta12/cdn
thanks,
Nick
#9
The latest 6.x-2.x dev imagecache at http://drupalcode.org/project/imagecache.git has utilized support for the CDN module!
Get it by: ->
a) wget http://ftp.drupal.org/files/projects/imagecache-6.x-2.x-dev.tar.gz -or
b) git clone --branch 6.x-2.x http://git.drupal.org/project/imagecache.git
Notes for this imagecache.dev module 'updates' are:
#10
There are some errors in the requirements. Currently it requires both imagecache.patch and imagecache_6--2.patch to be applied to remove that warning message, which is impossible because you can only apply one of them, depending on your imagecache version.
I've rolled a patch to correctly handle the requirements to be "either".
#11
I have Imagecache 6.x-2.x-dev installed and with the patch in #10, I see two of the warnings saying
"This patch has not been properly applied to the following files (or the patch has been updated)"
This may be my own error in applying the patch, and I will double-check.
#12
subscribing, same here. pressflow 6.22.104 and imagecache 6.x-2.0-beta12.
#13
same. pressflow 6.22.104 and imagecache 6.x-2.x-dev
#14
subscribe
#15
patch in #10 did not work.
#16
I have created a patch...it may not be the best way to do it, but it works. Open to suggestions.
#17
This patch fails when we try to apply it. What version of CDN are you applying to? We are using 6.x-2.1
#18
correction 6.x-2.x-dev
#19
it;s for 6.x-2.1
#20
The patch in #16 fixes a lot of things not really related to this issue. Also, it has a strange way of checking if we have imagecache 6.x-2.0beta12 (it checks if the file imagecache.module contains the word PressFlow).
Here is a patch that check if we have imagecache 6.x-2.0beta12 or later by looking at imagecache.info. The patch only does that; it does not try to fix any other issue.
#21
Awesome, I didnt think to check the timestamp, good work!
#22
thanks patch #20 fixes the warning for me, that was a bit annoying
#23
ok, small update:
my site works well without cdn module and is using imageapi 6.x-1.10 and imagecache 6.x-2.0-beta12. I have been playing around with stable and development branch of the CDN module and I also tried with and without patching drupal6.patch. When enabling the CDN module on the site I have absolutely no problems and my files are served from the CDN. When I try to add a new article though it seems like imagecache can't create the image presets. I'm not quite sure if this is related to this bug or not but anyway posting it here before opening a new bug.
maybe I am missing something but whatever I tried, it fails when creating new articles (with a custom field_image field)
#24
do you have phpgd or imagemagik installed on your server? And did you enable the corresponding drupal module, in the imageapi package?
#25
yes indeed, also tried both of them, none works (as the site was alive and working for months something must be related to CDN, though this could be because of my specific setup and the field_image, but I don't know)
also on a side note php doesn't seem to throw any related error for this
#26
This seems like a different issue and I would open a new bug report
#27
subscribe
#28
@mpranj & @pwaterz: yes, please file a separate bug report for that.
#16: patch is broken in too many ways to enumerate.
#20: thanks for the patch! However, it will fail when the ImageCache module's code is checked out through git instead of being installed via a tarball: the datestamp information is *only* available for tarballs, since it is added by packaging scripts! Nevertheless, this covers most cases, and thus I've committed it. I did add a warning regarding the tarball issue. Also no need to check for Drupal 5 though, so I removed that check.
Fix committed, based on #20: http://drupalcode.org/project/cdn.git/commit/dc97a78.
#29
Automatically closed -- issue fixed for 2 weeks with no activity.