Closed (fixed)
Project:
FileField
Version:
6.x-3.x-dev
Component:
User interface
Priority:
Minor
Category:
Task
Assigned:
Reporter:
Created:
2 Feb 2007 at 02:20 UTC
Updated:
27 Mar 2008 at 15:33 UTC
Jump to comment: Most recent file
they are gpl
I found them under http://forge.joomla.org/sf/frs/do/viewRelease/projects.docman/frs.docman...
There are both 32x32 and 16x16 icons. They are png, and looking quite good. There are .doc, .xpl and .ppt .pdf icons that most people will recognize from having just one look at them.
It would have been nice if icons would display in addition to the file ending.
Maybe even they could get into core? misc directory?
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | mimetypes-preview.png | 3.22 KB | yoroy |
| #16 | mimetypes-01.zip.txt | 5.23 KB | yoroy |
| #16 | mimetypes-01.svg_.txt | 196.35 KB | yoroy |
| #8 | mimetypes-16-sprite.png | 1.33 KB | yoroy |
| #8 | mimetypes-32-sprite.png | 2.29 KB | yoroy |
Comments
Comment #1
jpetso commentedThose icons don't exactly match the ones required by filefield (there are more, "unnessecary" icons in there). Also, what's the license on these icons? If they can't be licensed as GPL, they can't be included in any part of Drupal, including filefield.
Comment #2
morphir commentedthey are gpl AFAIK.
This is just a resource, I have not worked on this issue at all nor the icons.
Comment #3
moshe weitzman commentedthanks .. would be great to integrate into the module. maybe this could be a formatter?
- the uploaded file is a .tar file. rename on your client so it opens properly.
- the link where morphir found them no longer works so is a bit hard to veify the license.
Comment #4
jpetso commentedThe given URL is invalid by now, but I found the related project at a different one:
http://joomlacode.org/gf/project/docman/ or alternatively, http://www.joomlatools.org/
The icons are indeed GPL, as indicated by the project's FAQ:
http://forum.joomlatools.org/viewtopic.php?f=22&t=8
And the icon directory in the SVN browser is here:
http://joomlacode.org/gf/project/docman/scmsvn/?action=browse&path=%2Fdo...
That should be enough info to have a good conscience when including the icons... unfortunately, the ones in their current SVN trunk are different from those that you provided in the .tar.gz here. The attached ones look very much like original icons that were copied from Windows, and I would not be surprised if they were replaced for legal issues. On the other hand, the current SVN icons there are ugly as hell.
So, perhaps we can rather get legally harmless icons from other high-profile, original open-source icon themes like Tango or Oxygen. I'd like to rework the icon loading mechanism before including icons though, the icon should be determined by mimetype rather than extension.
Comment #5
dopry commentedand preferences for icons you icon hunters?
Comment #6
morphir commented@dopry: I dunno anymore.. We don't wanna bloat down interface with icons like joomla (1.5) has done.
Scenario:
If you do some attachments, like a pdf, word/ppt, txt..this could be a usability feature for recognizing that file type. Put them under misc/mime?
I don't want any large scale icons...just small (16x16 .gif/.png) mime icons for the most used file formats out there.
I guess we need some icons for the upcoming wysiwyg editor too (D7).
Comment #7
dopry commentedI'm strongly in favor of just 16x16 icons... I don't want big gaudy things... I mean you can theme big stuff in, but definitely not by default... I was also thinking of CSS'ing them in instead of writing code for it so I can be overridden more easily by designers.
Comment #8
yoroy commentedI'm working on mime-type icons, here's a sprite with icons for 'generic', 'text', 'image', 'audio' and 'video'. And yes, please do use CSS. Doing it with 1 sprite saves a few http requests too.
These icons are licensed under the GPL and were made especially for Drupal & filefield. And in theme-agnostic grayscale, too!
They are part of a larger Drupal specific icon-initiative and available in 32px and other sizes as well. I'll contribute the .SVG vector sourcefiles too, but I want to collect those in a more centralized manner than attaching them across different issues and queues.
What do you think?
Let me know which ones you'd like to see added or if you prefer to have them as seperate images.
Comment #9
yoroy commentedComment #10
dopry commentedI'd like them to be seperate images.. It will work with the existing infrastructure to support icons. Both sizes would be appreciated... While a single sprite would be quicker... I think it will be easier for users to update/replace them as single images.
Comment #11
morphir commented@dopry - I don't agree with dividing them up into separate images, sprite will result in fewer http-request, thus improve performance. And I think we should aim to make all graphics in core as sprites.
@yoroy - I like these icons. They are simple and clean - and makes a good start as they are generic. But if uploaded a pdf, what icon would it use?
Comment #12
morphir commentedI'm bumping this up to critical (bc it relates to usability) and moving the issue towards core.
Comment #13
yoroy commentedI think these are meant for the next version of FileField, not for core. Including them in core really is another issue.
Comment #14
dopry commentedYou can commit them as a single sprite, but I will split them up. Packing them all in one is premature optimization... and I don't want to have to alter it when I add pdf, svg, patch, xls, ods, etc, etc icons... Then the CSS has to change, its hard to support flexible naming, and it will be incompatible with other icon systems. I eventually hope for people to be able to drop in tango icons, or whatever if they want, and all of those use separate images per icon. I also agree this is kind of critical for filefield I know it's one of my higher priority issues to close. but we don't need to go battling over the priority. It's important to me so it will get committed as soon as there is a usable set of images offered up in a format I can work with... svg's per icon that I can generate rasters from would be ideal.
Comment #15
scottrigbysubscribe - thx :)
Comment #16
yoroy commentedOk, here's 12 icons!
- just the 16px versions for now
- added simple colors using the Tango palette
- these are 24bit PNGs
- filenames according to the freedesktop spec, took a guess on the PDF one though…
Also adding a SVG sourcefile for fun & reference, this is 1 masterfile that contains all basic variations on top of the generic file icon. This file created in Illustrator 10, it seems layers don't survive on opening in Inkscape. Still looking into that. But even if you had seperate SVG's for each, all generated bitmaps of 32px and smaller will look like crap without manual touchups, something to keep in mind…
Comment #17
yoroy commentedNeeds review, assigning to self.
Comment #18
dopry commentedYoRoy, they're awesome!!! You are the bomb diggity. I've wanted these for so long!! I'll try to update the icon code to use proper naming semantics... I'm not much of an aesthete, but this will be an awesome start... Is there a name for this icon set?
Comment #19
aaron commenteddefinitely do it as a sprite.
it's a themeable function, so themers/developers would be able to override them on an individual basis if they wanted.
Comment #20
yoroy commentedYay! So glad you like them. Next up are some for Date/Event as requested by KarenS.
I'm trying to come up with generic looking icons, so for now the working title of the set is 'Protocons' :)
Comment #21
dopry commentedOkay the png icons are committed to DRUPAL-5--2... they're hackishly implemented, but I didn't want to get into fussing with the UI too much until 2.3 is official, so I left it that way... 2.4 will see a more freedesktop like implementation. I already have a patch for most of it...
Comment #22
scottrigbyGreat - thanks!
I want to test this, but can I first ask:
Should I un-install the last version of FileField first, or just copy the new module over the old one (I'm asking, are there any differences in the tables, etc)? I want to test but make sure to install properly first
Thanks & look forward to checking it out
:)
Scott
Comment #23
morphir commentedcan you please explain what this means?
Comment #24
yoroy commentedMorphir: http://standards.freedesktop.org/icon-naming-spec/
I think (hope!) dopry means implementing them in such a way that other existing icon sets could be dropped in as well (read his comment #14).
Dopry, if that IS your plan, I'd love to learn more about it! There's a few designers anxious to get started drawing more Drupal specific icons. It would be good to know we should conform to this spec if there'se code being written that enables this.
Comment #25
morphir commentedwait now. This is for naming conventions for the desktop. I agree going with naming conventions for drupal, but is this really necessary for drupal?
Shouldn't drupal have it's own naming convention instead?
We are planning the very first drafts of Drupal Human Interface Guidelines these days, and icons are a part of that. Let's not forget that.
We need naming conventions, but does the free desktop apply? (I dunno, so I ask)
Comment #26
yoroy commentedLet's continue this discussion in the icon group on g.d.o: http://groups.drupal.org/icons-drupal
I posted some starter files and specs for discussion here: http://groups.drupal.org/node/9739
Thanks.
Comment #27
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.