I cannot re-order my nodes within the queues. After dragging them into place and hitting save, I always receive this warning:

Warning: Wrong parameter count for array_unique() in nodequeue_save_subqueue_order() (line 1337 of /path/to/nodequeue/nodequeue.module).

CommentFileSizeAuthor
#9 1152240-wrong_parameter_count_for_array_unique-5-D6.patch670 bytesamateescu
#5 1152240-wrong_parameter_count_for_array_unique-5.patch670 bytesamateescu
#3 1152240-wrong_parameter_count_for_array_unique.patch597 bytesamateescu

Comments

amateescu’s picture

amateescu commented

This was introduced by #1110954: Provide a nodequeue_save_subqueue_order_alter hook to allow other modules to respond to and affect the sort. A quick fix would be to update you php to a version higher than 5.2.9 and I will come up with a proper fix shortly.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

subscribe. Sorry about this.

amateescu’s picture

amateescu commented
Status: Active » Needs review
StatusFileSize
new 1152240-wrong_parameter_count_for_array_unique.patch597 bytes

Let's try this patch :)

eriknewby’s picture

eriknewby commented

Unfortunately still throwing the same warning for me at line 1333.

PS - impressively fast response time. Thanks for all the hard work you do!

amateescu’s picture

amateescu commented
StatusFileSize
new 1152240-wrong_parameter_count_for_array_unique-5.patch670 bytes

@eriknewby, thank you :)

Are you running on 7.x-2.x-dev downloaded from drupal.org or from git? I'm asking because i commited some patches in the meantime that changed the file structure a lot, so you'll have to upgrade to a new -dev when it will be packaged by the d.o buid script (probably later today), or if you're on git, just pull the latest changes (and don't forget to clear the cache and run update.php).

Anyway, here is another patch for you to try. If you don't want to wait for another -dev and you're not on git, i guess you could apply these changes manually to nodequeue.module and post the results.

eriknewby’s picture

eriknewby commented

@amateescu the patch works great! I applied it manually for now just to be safe. Thank you!

amateescu’s picture

amateescu commented
Status: Needs review » Fixed

Commited to 7.x.

http://drupalcode.org/project/nodequeue.git/commit/a39a8ad

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Fixed » Needs review

Shouldn't this also go into 6.x branch?

amateescu’s picture

amateescu commented
Status: Needs review » Fixed
StatusFileSize
new 1152240-wrong_parameter_count_for_array_unique-5-D6.patch670 bytes

Of course it should, thanks for keeping an eye on it :)

Commited attached patch to 6.x.

http://drupalcode.org/project/nodequeue.git/commit/3f29ccd

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.