Problem/Motivation

There's no pager on the revisions list, so it doesn't scale once you get to hundreds of revisions.

Proposed resolution

Add a pager to the revisions list. If the list is longer than 50 revisions a pager appears.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 diff_add_preview_changes_and_pager_4-7-x_2.patch7.4 KBrötzi
#2 diff_add_preview_changes_and_pager_4-7-x.patch7.37 KBtoemaz
diff_add_preview_changes_and_pager.patch7.69 KBrötzi

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Fixed

terrific patch. i just made rotzi a maintainer of this module.

committed to 5.0 and HEAD. hopefully someone will make a patch for 4.7.

toemaz’s picture

toemaz commented
Version: 5.x-1.x-dev » 4.7.x-1.x-dev
Status: Fixed » Patch (to be ported)
StatusFileSize
new diff_add_preview_changes_and_pager_4-7-x.patch7.37 KB

I applied the head patch to the 4.7.x version and then tried to solve the errors. Now, it does not complain anymore, but I can't get the 'preview changes' to work. I'm not trained enough to quickly see where the problem comes from. I gave up after 15 min.

Anyway, here is my patch for 4.7.x which needs some work!

rötzi’s picture

rötzi commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new diff_add_preview_changes_and_pager_4-7-x_2.patch7.4 KB

You missed a change in the forms handling. The button press has to be checked differently in 4.7 than in 5.0.

Try the new patch.

rötzi’s picture

rötzi commented
Status: Needs review » Fixed

patch applied to cvs

toemaz’s picture

toemaz commented

Hi rötzi,

Thx for committing this! I've testing it and it seems everything is ok.
Just one remark: I would like to be able to hide the 'preview changes' button.

The solution would be to create an extra access permission or create a setting variable where you can disable it. Or you can hook it into the admin/settings/node form.

I can create a patch for this but what so you think would be the best option?

moshe weitzman’s picture

moshe weitzman commented

this button is already protected by 'view revisions' permission. if that is not sufficient, i suggest writing a little module which uses hook_form_alter() to hide the button as desired. i don't want many preferences if possible.

toemaz’s picture

toemaz commented

Ok, that will work. Thx for th feedback Moshe.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
BioALIEN’s picture

BioALIEN commented
Status: Closed (fixed) » Active

Moshe, I think toemaz had a valid suggestion. There should be an access control to hide the "Preview changes" button from node edit. Reason is because this button makes it very confusing when editing other modules such as webform. I know my way around Drupal and this module caught me out. So imagine what it can do to other admins who are not so familiar?

BioALIEN’s picture

BioALIEN commented
Status: Active » Closed (fixed)

Going to close this again in favour of the newly created thread.
http://drupal.org/node/115411

catch’s picture

catch
he/him
Primary language English
commented
Title: Show changes button on node edit form and pager in revisions list » Revisions list should have a pager
Version: 4.7.x-1.x-dev » 8.x-1.0-alpha2
Assigned: rötzi » Unassigned
Category: Feature request » Bug report
Priority: Normal » Major
Issue summary: View changes
Status: Closed (fixed) » Active

This is still a valid issue nine years later. If you have a lot of revisions, the page will eventually hit the memory limit or max_execution_time.

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-1.0-alpha2 » 4.7.x-1.x-dev
Category: Bug report » Feature request
Priority: Major » Normal
Status: Active » Fixed

Apparently I didn't read #1, and this was actually committed to 5.0 originally.

That means somewhere between 5.0 and the 8.x branch it's regressed, so closing this as fixed again, will open a new one.

catch’s picture

catch
he/him
Primary language English
commented
Status: Fixed » Closed (fixed)

#2746069: Needs tests: No pager on revisions listing is the new issue.