After attempting to resolve the issue at #1147510: Rework logic to initialize all facet builds earlier in the application flow, I experienced many application flow problems. The API to needs to be reworked to eliminate the need to override adapter code allowing for Facet API to make flow changes without disturbing the backend.

CommentFileSizeAuthor
#2 facetapi-1152368-2.patch2.11 KBcpliakas
#1 facetapi-1152368-1.patch2.11 KBcpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new facetapi-1152368-1.patch2.11 KB

The attached patch adds the API change. This change is necessary for the refactoring happening in the initialization-flow-1147510 branch.

cpliakas’s picture

cpliakas commented
StatusFileSize
new facetapi-1152368-2.patch2.11 KB

Reworked method names to be more transparent about what they are actually doing.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Looking through the code, this patch was committed at ac17062 along with the resolution to issue #1150662: Facet blocks not remembering overridden settings. Marking as fixed.

cpliakas’s picture

cpliakas commented

Note that Apache Solr now needs the patch at http://drupal.org/node/1152382#comment-4451994 to work with the latest version of Facet API.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.