PHP 5.3 / Parameter 2 to automenu_node_automenuapi() expected to be a reference [#1152810]

Hopefully I haven't missed a similar bug in the queue.

Drupal 6.20
PHP 5.3.2

Installed and enabled automenu API and node sub-module, and got the dreaded WSOD trying to access the modules page, and reports pages. Other admin pages were fine.

The following PHP error was reported:

Parameter 2 to automenu_node_automenuapi() expected to be a reference, value given in {webroot}/includes/module.inc on line 462.

The $params parameter is set up as a reference var. Since the function doesn't update $params, I simply removed the & to remove the error, and haven't had any problems yet (I've successfully set up a content type to auto-add a menu item).

I know I've seen this error thrown with PHP 5.3 when objects were being passed by reference, but $params is being accessed as an array, and not causing any issues that I've come across, so not sure if my "fix" is proper or not.

Comment	File	Size	Author
#8	Bugfix.patch	918 bytes	tehnodeer

Comments

Comment #1

sammo commented 12 May 2011 at 21:27

Comment #2

Johnny vd Laar commented 13 May 2011 at 11:44

I've committed a fix for this problem so please let me know whether this resolves your issues.

Comment #3

Johnny vd Laar commented 13 May 2011 at 11:44

Status:

Active

» Needs review

Comment #4

Helrunar commented 20 June 2011 at 23:23

I have tested it with PHP 5.3.5 and all work fine ;-)

Comment #5

amilne commented 12 July 2011 at 14:08

Status:

Needs review

» Closed (fixed)

Apologies for the lack of response; seems my email notifications are disabled. I've installed this module on two new sites since, and had no issues, so problem solved - thanks Johnny!

Comment #6

Anonymous (not verified) commented 11 April 2012 at 20:40

Drupal 6.25 and version 2.0 of this module keep returning this error as well as a WSOD.
I am using the dev version now, and it seems to be ok.

I've tried reinstalling the module using DEVEL reinstall feature but to no avail. I'm not sure which database entries to delete to wipe it completely.

Has anyone experienced the error again? I can't even use the update.php feature to make any database updates, and clearing cache/running cron does nothing as well. I get WSOD on almost every page.

dev 2.x version seems to be ok?

Comment #7

sdowney2002 commented 7 May 2012 at 18:15

Status:

Closed (fixed)

» Needs work

I'm having the same issue as Careless. Running 6.25 and installed 6.x-2.0 yesterday. This morning, my hosting provider upgraded to PHP 5.3 and I got WSOD on /user pages. Watchdog also reported the "Parameter 2 to automenu_node_automenuapi() expected to be a reference" error as well.

Had to disable AutoMenu via the database.

Sorry, but I'm re-opening this ticket.

Comment #8

tehnodeer commented 8 May 2012 at 13:32

Status:

Needs work

» Needs review

Status	File	Size
new	Bugfix.patch	918 bytes

Guys, got a solution. Try it and give feedback!

Comment #9

sdowney2002 commented 17 May 2012 at 18:47

That bugfix patch seems to have done the trick. Thanks so much!

(Drupal 6.25 Automenu 6.x-2.0)

Comment #10

puddyglum

English

Elk Grove, CA

commented 21 May 2012 at 22:25

Yes, #8 did the trick and I don't see how it will cause any problems. Probably need to commit #8 soon as I've seen other developers say they couldn't get this module to work...

Comment #11

aiphes

French

commented 1 June 2012 at 09:46

same issue :
Parameter 2 to automenu_node_automenuapi() expected to be a reference, value given module.inc:476

with php 5.3.10...hope an update of the module fix this

Comment #12

Anonymous (not verified) commented 3 October 2012 at 01:01

#8 did it for me, I was having admin screen white screen of death, and found the error being recorded in the database log.
I had just update php to 5.3 from 2.x