The renaming of the application is not properly done.

update_sql() does not support substitution as db_query does.

Attached is a patch that build the SQL using PHP substitution rather than %-substitutions.

I am renaming 6301 to 6302 so it's done again properly. This should do the trick ad the app label wasn't really change but the fb_connect variable was, this would just re-set it properly and change fb name and delta

BTW, why was this made?

CommentFileSizeAuthor
fb-app-update-6301-error.patch1.75 KBhanoii

Comments

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Title: Update 6301 error - renaming of the application name is done incorrectly » rc12 - update 6301 error - renaming of the application name is done incorrectly
hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Active » Needs review
hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

Also a minor thing but added newline in the end to adhere to Drupal's Coding Standards:

All text files should end in a single newline (\n). This avoids the verbose "\ No newline at end of file" patch warning and makes patches easier to read since it's clearer what is being changed when lines are added to the end of a file.

Dave Cohen’s picture

Dave Cohen commented
Assigned: Unassigned » Dave Cohen

Oops. I thought update_sql() worked that way and because my labels were all lower case, the code was not properly tested. Thanks for the report.

See #1124082: Connect block of apps with labels containing capital letters always shows default values for the reason.

Dave Cohen’s picture

Dave Cohen commented
Status: Needs review » Fixed

Your patch is in rc13. Thanks again.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.