Convert leading %23 to "#". The second one is fine. Here's an example:

/%23tabs-1?quicktabs_timecutter_quicktab_block=1#quicktabs-timecutter_quicktab_block

on this page: Toro SS3200

CommentFileSizeAuthor
#3 hash-patch-1153358-2.patch596 bytestcmug
#1 hash-patch-1153358-x.patch493 bytestcmug

Comments

tcmug’s picture

tcmug commented
StatusFileSize
new hash-patch-1153358-x.patch493 bytes

Funny bumped into the same bug in a different context: ours is related to users clicking on quicktab links before the browser has finished loading the js (this of course happens to people who do not run js at all).

Problem is with this piece of code:

    $tablink = array(
      '#type' => 'link',
      '#title' => $tab['title'],
      '#href' => '#tabs-'. $i,
      '#options' => _quicktabs_construct_link_options($quicktabs, $i),
    );

I don't know what the improperly added fragment #tabs- is used for, but swapping it to drupal_get_destination() fixes it.

Patch attached.

drewschmaltz’s picture

drewschmaltz commented

tcmug - thanks for solving this. It returned an array for me so I needed something like:

foreach ($quicktabs->tabs as $i => $tab) {
  $href = drupal_get_destination();
  $tablink = array(
    '#type' => 'link',
    '#title' => $tab['title'],
    '#href' => $href['destination'],
    '#options' => _quicktabs_construct_link_options($quicktabs, $i),
  );
  $tablinks[] = $tablink;
  $index++;
}
tcmug’s picture

tcmug commented
StatusFileSize
new hash-patch-1153358-2.patch596 bytes

Ofcourse, dammit!

Funny it threw no errors on our setup - must be casting it in someplace to a string directly.

Anyways heres the proper working patch.

drewschmaltz’s picture

drewschmaltz commented
Status: Active » Reviewed & tested by the community

Updating status.

katbailey’s picture

katbailey commented
Status: Reviewed & tested by the community » Fixed

OK, committed here http://drupalcode.org/project/quicktabs.git/commit/b7ac65d but I changed it so that the href is to the current page ($_GET['q']) - this is for graceful degradation without javascript, i.e. clicking on a tab will reload the current page with the selected tab active.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.