There seem to be certain situations (suphp) where it's not yet clear if this module is doing an accurate job of detecting editable files. We should attempt to write a file and edit a different file (probably one included with this module such as a TEST.txt) to see if the operation succeeds. Nothing beats performing the exploit as a way to test if the configuration is vulnerable to it...
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | security_review-suppress-warnings-d6-1153486.patch | 1.01 KB | coltrane |
| #9 | security_review-suppress-warnings-d7-1153486.patch | 878 bytes | coltrane |
| #2 | 1153486_attempt-file-creation-test_2.patch | 3.97 KB | greggles |
| #1 | 1153486_attempt-file-creation-test.txt | 5.82 KB | greggles |
Comments
Comment #1
gregglesAnd here's an attempt.
Comment #2
gregglesNow with the IGNOREME.txt file.
This also applies to 7.x and should apply to 6.x.
Comment #3
BrockBoland commentedWorks great.
Patch applies cleanly on 6, but on 7 it choked on that last chunk - removing the space after
'html' => $html,. Since that was just a whitespace cleanup, I don't think it's a problem.Comment #4
coltraneThe file_write_test files should be cleared routinely. The check itself could remove previous files or cron could. Of course, once the check is secured files won't be removed.
Comment #5
coltraneSpoke with greggles little more and accept that some files will stay around until the user fixes the problem.
Committed http://drupalcode.org/project/security_review.git/commit/1c9914a and http://drupalcode.org/project/security_review.git/commit/9577d58
Comment #6
gregglesThanks, Ben!
Comment #8
coltranewarning: fopen(./sites/all/modules/contrib/security_review/IGNOREME.txt): failed to open stream: Permission denied in /Users/bjeavons/dev/modules/security_review-6.x-1.x/security_review.checks.inc on line 34.Just need to suppress warnings on that fopen I think.
Comment #9
coltraneComment #10
gregglesSeems good to me, I didn't test.
Comment #11
coltraneFixed and committed to both branches