For those of us that like to manage our backups with Hosting Backup GC module, we need to have all the backups being recorded in the hosting_site_backup table. This isn't happening when doing a site clone/migrate. This can be a problem on large sites as these files can be huge.

There is a simple fix, we can add:

// Also record the backup created.
hosting_site_post_hosting_backup_task($task, $data);

To hosting_clone_post_hosting_clone_task and hosting_clone_post_hosting_migrate_task and then the backup file will get added in the front-end.

Comments

anarcat’s picture

Assigned: Unassigned » anarcat
Priority: Normal » Major

i agree this is an important issue - i'll take a stab at it.

anarcat’s picture

Status: Active » Patch (to be ported)
steven jones’s picture

Yeah, so actually I've had the following code in production for a little while now (on a 1.x base)

    // Also record the backup created.
    $task->task_args['description'] = t('Pre-migration backup');
    hosting_site_post_hosting_backup_task($task, $data);

So that the backup additionally gets a useful description. Otherwise it works fine.

anarcat’s picture

Steven, can you commit this to head?

steven jones’s picture

Added the follow up to 7.x-2.x, this is working for me in 6.x-1.x branch too.

steven jones’s picture

Status: Patch (to be ported) » Fixed

Pushed into 6.x-1.x too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5ab95f1 on 7.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #1154108 by darthsteven - record backups from clone and migrate
    
    
  • Commit 196fc13 on 7.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Follow up on issue #1154108 by Steven Jones.
    
    Add an additional...

  • Commit 5ab95f1 on 7.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by anarcat:
    #1154108 by darthsteven - record backups from clone and migrate
    
    
  • Commit 196fc13 on 7.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Follow up on issue #1154108 by Steven Jones.
    
    Add an additional...