Notices thrown in template.php
Notice: Use of undefined constant skinr - assumed 'skinr' in mothership_preprocess() (line 362 of /data/sites/mysite/htdocs/sites/all/themes/contrib/mothership/template.php).
Patch corrects cases where module_exists() was passed a constant instead of a string.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | mothership-notices-1154760-6.patch | 9.31 KB | lazysoundsystem |
| #5 | mothership-notices-1154760-5.patch | 8.99 KB | lazysoundsystem |
| #4 | mothership-notices-1154760-4.patch | 9.03 KB | coltrane |
| #2 | mothership-notices-1154760.patch | 8.1 KB | coltrane |
| #1 | mothership-notices-1154760.patch | 3.78 KB | coltrane |
Comments
Comment #1
coltraneFound some more.
Comment #2
coltraneFound more having to do with theme settings. When the constant isn't defined PHP attempts to use it as a string, which is why this never popped up before.
By the way, http://randyfay.com/node/76 is what anyone who writes PHP (even in themes) should read and follow.
Also finding notices "Array to string conversion" from mothership_id_safe(). I think it's because mothership_table() is passing $cell over for an ID sometimes and it's an array. Will tackle in moment.
Comment #3
coltraneComment #4
coltraneAnd this one includes a fix for
Warning: strtolower() expects parameter 1 to be string, array given in mothership_id_safe() (line 13 of /data/sites/site/htdocs/sites/all/themes/contrib/mothership/template/template.functions.php).Comment #5
lazysoundsystem commentedThanks for these fixes - the patch added below is exactly the same, only made with
--no-prefixfor compatibility with drush_make.(And with trailing whitespace removed from the changed lines - there are other lines still with trailing whitespace.)
Comment #6
lazysoundsystem commentedAnd this patch also fixes these two:
Comment #7
realityloop commentedIf this is still an issue in D7 please re-open and update the version in issue metadata