Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.This module adds a trailing slash to all Drupal generated URLs:
http://drupal.org/sandbox/Akaoni/1145254
The Australian War Memorial needs this functionality so we could migrate our website to Drupal without breaking the current URLs. We couldn't find any other modules that do this and searching on the 'net shows that it's not an unpopular request.
We will continue to work with and develop for Drupal 7.
As we do, we would like to contribute more modules and updates etc.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | trailing_slash-1154778-10.patch | 5 KB | tim.plunkett |
Comments
Comment #1
dave reidPossibly could you help finish up this feature for Global redirect rather than starting a new project? #920198: Enforce Trailing Slash Option
Comment #2
Akaoni commentedI had thought of this, however redirection and rewriting are different mechanisms and I didn't want to muddy the waters.
This module modifies outbound URLs (like the core Path module) rather than enforcing incoming URLs (as Global Redirect, mod_rewrite, or IIS URL Rewrite does).
Using Global Redirect to enforce trailing slashes is still a great idea for those who can't or don't want to use mod_rewrite, or IIS URL Rewrite. Once this feature's added I'd be more than happy to add Global Redirect as another way to enforce trailing slashes on this project's page.
Comment #3
jordojuice commentedFair enough.
Initial screening needs work:
-Please add a README.txt file to your module detailing instructions on installation and setup of the module
Doxygen comments need to be directly above associated functions or php will not associate the documentation with the function. So, no blank lines between comments and functions.
Inline
//comments should start with a space, capital letter, and end with a period.You should not have to set variables in hook_enable(). Use of variable defaults can eliminate this need.
Overall, the module makes good use of Drupal coding and commenting standards. Nicely done! Not much work for me at this point.
Please make the recommended changes and set this issue back to "Needs review" once the changes are pushed to your sandbox. Thank you for your contribution and good luck!
Comment #4
jordojuice commentedUpdating tags
Comment #5
Akaoni commentedThanks heaps for the review, jordojuice!!
Changes made.
Comment #6
jthorson commentedA couple small issues in the globalredirect_form_alter routine, on the [#description] line, as mentioned in IRC:
- wrap the #description value in a t() call,
- Use l() to define the link, as the current version will not be compatible with clean_urls disabled.
Comment #7
Akaoni commentedThanks for reviewing, jthorson!!
Fixes committed.
Comment #8
jthorson commentedLooks good ... clean and simple.
Marking RTBC, and a git admin should be around to grant access once the DrupalCon excitement winds down.
Comment #9
Akaoni commentedwoOtz!!!
Thanks again, jthorson!! ; )
Comment #10
tim.plunkettHere's a patch to clean up some more coding standards issues.
Postponing for the short-term, I will ping Dave Reid about his comment in #2. While a lightweight alternative, I'm not sure this needs to be a full project.
Assigning to myself, so I don't lose track.
Comment #11
Akaoni commentedCoding standards fixed.
If it is decided that this should not be a full project, can I please still be approved as a git contributor?
I'd really like to not have to submit a different project and then wait another 3-4 months.
Comment #12
Akaoni commentedAs per Dave Reid's suggestion, comment posted:
http://drupal.org/node/920198#comment-4923164
Comment #13
tim.plunkettAfter discussion with Akaoni about collaboration, closing this for now.