Hi
I'm using the Danland theme. copied the 'page--external.tpl.php' into its main directory.
no further changes were made.

I see on the status bar that 'external' was added to the link. but activate the external link only producing error 404: page not found.

any ideas why its not working for me ?

Comments

my.wahyu’s picture

Assigned: Unassigned » my.wahyu

same as me.
I have try combination rename as external.tpl.php (like modul external iframe D6), put it folder template, theme one by one.
I try to edit D6 code and D7 code .. its still 404
but nothing change.. and external link produce http://www.gastia.com/404 : page not found.
How to make external link like this at TRY DEMONSTRATION http://emcwebsolutions.com/external?url=http://www.sylvielemieux.ca
Thanks A lot
______________________________________
http://www.gastia.com

stongo’s picture

Status: Active » Fixed

Please download 7.x-1.0-beta4 and this should work.
I hadn't used git properly when creating the 7.x releases, so I apologize. Hopefully this one works.

stongo’s picture

Status: Fixed » Closed (fixed)
jonabh’s picture

Sorry, but still not working for me.
any Ideas ?
Do you do more then it written in the documentation ?

stongo’s picture

Status: Closed (fixed) » Needs review

Can you try beta5? Thanks for your patience and testing :) You should only have to enable the module and make sure you create a virtual host entry if it is a local setup ie. foobar.loc:8989 instead of localhost:8989/foobar.
I had mis-named the drupal 7.x-1.x branch in git and that was causing problems.

jonabh’s picture

again sorry, but still not working for me

few questions:
1. what do mean by creating a virtual host entry, and why ?
2. If its possible, please update the documentation

Many thanks

stongo’s picture

I have tested beta5 and can confirm it works as designed. If you previously had external-iframe installed, make sure to disable it in the modules page, and then re-enable beta5.
I have updated the documentation page with a problem solving section, that addresses the localhost setup.

jonabh’s picture

Still getting the 'file Not found' even tried without coping the 'page--external.tpl.php' into the theme location.
Maybe I'm not copying in to its right location? or should I change its name? should I edit it or can it works with its default code?

Thanks

stongo’s picture

You don't have to copy page--external.tpl.php to your theme for the module to work.
Can you please describe your environment where you are testing it so I can get some more information to try to reproduce the error?

jonabh’s picture

My environment:
client: win7 64bit
server: Linux, PHP 5.2.17, MySql 5.0.92, Apache 2.2.17, Drupal 7, Theme: Danland

Thanks

stongo’s picture

Status: Needs review » Closed (cannot reproduce)

yuval.j.benhur, I cannot reproduce this using the setup you described. Make sure you are using beta5, but otherwise I'm not quite sure.
To test, I did this and it worked fine:
1) enable external-iframe-7.x-1.0-beta5
2) make a test node with one relative link and one absolute link
3) relative link works as normal, absolute link gets rewritten and opens up in iframe
There's no configuration necessary for it to work.

jonabh’s picture

Thanks stongo

sorry for the late answer, but it seems to work for me too. beta5 did the trick.
but still its not working when using IExplorer. is a known limitation ?

leemazong’s picture

Version: 7.x-1.0-beta3 » 7.x-1.0-beta5
Status: Closed (cannot reproduce) » Active

Hello,
when i use your module my external links make a 403 Forbidden page (You don't have permission to access /external/ on this server.)...

I don't understant, my config is :
client: winXP
server: CentOS, PHP 5.3.3, MySql 5.0.77, Apache 2.2.3, Drupal 7.8, Theme: mayo

(for information the vhost is available only in the intranet and the server can't access to internet.)

i have copied the module directory in the site/all/modules/external-iframe
i have enabled the module in the admin interface
i have a vhost named "maq-drupal" on port 80

Where is the problem? I have seen the externals urls were rewrote like this : http://maq-drupal/external/?url=http://www.google.fr

Do I need to create a directory named "external" in my drupal repository? (I try to make this directory with chmod 777 chown apache:apache)
What should be the content of this "external" directory?

Thanks for your help, I really need this module.

michaek’s picture

A lot of this sounds like it might be the result of the Javascript URL munging not respecting Drupal's base path. That'll only happen if the Drupal install isn't in the server root for the domain (located at /). This patch should resolve that.

stongo’s picture

Michaek, thanks for the patch. The 2.0 version uses Drupal.settings.basepath that exact same way you have in the patch. Look for dev release next week!

michaek’s picture

Any chance you can get this patch into a 1.x release so it's usable for folks in advance of a stable 2.x release?

stongo’s picture

7.x-1.x-dev and 6.x-1.x-dev has this change in the JS already rolled in. Please use the 1.x-dev release - it should be stable for production.

stongo’s picture

Status: Active » Closed (fixed)
nguyentran’s picture

Thanks for the patch, it works for me.

liliplanet’s picture

make sure you have clean urls enabled :)