FileField Paths should support comments (and any other entities) with file fields

When does FileField Path support the taxonomy filefield ?

@Aleanar: See #1217732: Files attached to taxonomy terms are not processed.

I was close two other issue with duplicated. (Join forces :-) )
http://drupal.org/node/1217732
http://drupal.org/node/1243680

I am working on this issue, but the patch is not ready yet.

@Sweetchuck, when do you plan to publish the patch? I started to work on this also, but if you're almost ready, I'd prefer to stop.

@maximpodorov, we need to discuss the new API. I would like to support that fields where not just one FID is stored.
Although most common used fields (file, image) store only one FID. But if somebody create a new field type with two or more FID (fid1, fid2, fid3, …) with separated file_directory settings filefield_paths cannot support that.

Now not too easy to add new cleanup methods. (tolower, pathauto, transliterate). I would redesign this part too.

My questions are:
Why necessary the {filefield_paths} database table?
And not exactly clean to me how the retroactive update works. Why need two checkboxes (Retroactive update, Active updating)

Here is an ultra very development version :-)
This is just a concept. Lot of works need.
I temporary remove some features, such as batch update, and text field value rewrites.
But (maybe) work with any entity types, and with any file reference field. Not just with the "file" and "image" fields.
Please send feedback.

Does it update existing data in filefield_paths table?

Not. If this direction will be approved, then need to write the update hooks.
I do not want unnecessary work.

I ran into this issue with Profile2 and ended up filing a dupe issue because I didn't know this was a more general problem. So adding in some search candy: Profile and Profile2 and imagefield paths on Profile2 entities

There, hope that helps the next Profile2 user. :)

Michelle

subscribing. Waiting until this supports fields on profiles

Subscribing - I was trying to make it work with a custom entity, no luck...
For reference: this means at the actual state it does not work with file fields attached to entities created with modules like eck, field_collection, etc.
I'm gonna test the patch in #9

Subscribing, just stumbled across this and would love to see FileField Paths to support entities (especially when it comes to translations).

Subscribing, I just came across this issue

Latest dev supports all entity types (that I've tested), with the exception of field_collection, but that will be remedied.

Thanks!

Michelle

The latest dev doesn't work for taxonomy term entity.
Looks like the latest dev doesn't work even for nodes. The files are not renamed when saving nodes.
No, the problem for nodes is Filefield Paths settings were lost after upgrading to the latest dev. I had to reconfigure node fields, and now files are renamed. But the problem with taxonomy terms is not fixed.

Issue with Taxonomy terms and other Entities (including Field Collections) is now fixed and committed.

Nodes already worked, it's just a case of needing an upgrade path, and given this is still a dev then I don't see the upgrade path yet to be necessary. It will be in place before the next stable release though.

I confirm it works for taxonomy terms. But term tokens are not available for FileField Paths. Is it possible to add them?

You are correct, tokens are not yet Entity aware, this does need to be fixed but I would ask that you open another issue for this.

I created #1327194: Support specific entity tokens for this task.

Tested the latest dev against custom entities created with Entity Construction Kit (ECK), seems to works well.
Thanks a lot @Deciphered for taking the time to commit all those changes.

Thanks @Deciphered, didn't realize how much I needed this module until I didn't have it.

I hate to say it, but I think this patch missed a data migration step.

I had previously setup paths and names images in most of my content types, but now when I go to the settings page for that field I find that it has returned to the default.

Looking at the filefield_paths table, I understand why: in the type column I see two different sorts of entries content type only for all the fields I had set previously, and "node::" entries for the fields I've gone back to correct.

As another note, I also see entries for content types I've since deleted.

That's unfortunate that it was missed, but the module is still just in beta/dev and issues like this may occur. I will try to prevent such issues in the future.

However, please don't re-open closed issue, instead create a new issue and reference this issue if you believe it is related.

Any update with Profile2 file entities support?