These 2 patches adds a select box in the settings form of panes where you can select which HTML element to wrap the title in.

The first patch is for panels and the second one is for ctools. You need to apply both to get the selectbox.

I'm using this on a production site now and it works fine.

CommentFileSizeAuthor
#1 make-title-elem-selectable-ctools-1155266-1.patch1.55 KBemattias
#1 make-title-elem-selectable-panels-1155266-1.patch990 bytesemattias

Comments

emattias’s picture

emattias commented
StatusFileSize
new make-title-elem-selectable-panels-1155266-1.patch990 bytes
new make-title-elem-selectable-ctools-1155266-1.patch1.55 KB

Here are the patches

I didn't get 100% why the submit handler wasn't always added to the ctools_content_configure_form_defaults (in content.inc) form but I set it to always add it and it seams to work. If you know, please let me know..

I see this as a (first?) step in making panels/ctools more semantic, like views 3 is!

merlinofchaos’s picture

merlinofchaos commented

I think this is probably the wrong place to do this. This would need to be in the 'style' settings, because the style actually controls the display of the title. Note that there is at least one style that doesn't display a title at all.

Plus, that way, it is a patch only for Panels, not CTools.

emattias’s picture

emattias commented

Yes, but then this feature is only available for the styles that implement this solution. I think this is a feature that many would like to have no matter what style is used.

merlinofchaos’s picture

merlinofchaos commented

But what about styles that don't use theme('panel_pane')? Styles use their own themes.

emattias’s picture

emattias commented

For example right now I'm building a site using the precision theme which provides a grid style where you can give every pane a certain grid column width. If this solution was included in ctools/panels I would be able to select the semanticly correct element for the title and still be able to style the panes according to the grid without needing to implement this solution in the theme.

I think this is a feature that should be included in the modules not be theme overrides, just like it is in views.

merlinofchaos’s picture

merlinofchaos commented

You didn't answer my question in #4. In fact, you completely ignored it. For styles that don't use theme('panel_pane') this will be lame. The setting will be flat out ignored and there's no dealing with it.

And for the theoretically things that are using content_types and NOT using Panels at all (in theory they can exist) it's even weirder.

emattias’s picture

emattias commented

Sorry, my answer to your question in #4 is that if this functionality is in panels "core" the styles will implement this too.

Or maybe you could allow the styles to alter the form if they feel that the style shouldn't have a selectable title element.

Regarding the content_types and no panels I'm not sure what you are referring to. Could you give an example?

merlinofchaos’s picture

merlinofchaos commented

In theory, dashboard module is using CTools' content types.

I'm just not comfortable having HTML tags here, when it should more correctly be in the style section.

emattias’s picture

emattias commented

I've made a patch to the Precision theme that adds this functionality: #1273390: Make titles HTML element selectable (patch inluded)

I still think this should be available for all panes though.. :P

c.hill’s picture

c.hill commented

but html heading tags aren't just for style, they are used to give the page structure. I think i kinda want to control which tag gets used without worrying about what it is going to look like.