Fix coding standards issues

If you can point to anything that doesn't adhere to Drupal coding standards, great. If you can submit a patch, even better.

This fixes everything except implementing dependency injection.

Reviewed patch #2, looks good to me.

It applied cleanly and fixed the phpcs issues except the below issues that need to be fixed as well:

FILE: /tac_lite/src/Form/UserAccessForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
  40 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
  41 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  63 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 103 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Form/SchemeForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
  98 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
 184 | ERROR   | Type hint "array" missing for $default_values
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Form/ConfigForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
  33 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
  89 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 109 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Cache/TacLiteGrantsCacheContext.php
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------

Please fix these issues as well.

Thanks!

This patch adds the array type declaration.

Implementing dependency injection is far more complicated. It should to be done in a separate ticket.

Hi, I ran phpcs against patch #4 and got back just dependency injection warnings ..

###############################################
👻️ ~/Documents/Sites/D9.5.0  phpcs --standard=Drupal,DrupalPractice --ignore=PATCHES.txt --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/tac_lite

FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Form/SchemeForm.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
98 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------

FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Form/ConfigForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
33 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
89 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
109 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------

FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Form/UserAccessForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
40 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
41 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
63 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
103 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------

FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Cache/TacLiteGrantsCacheContext.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------

Time: 140ms; Memory: 10MB
######################################

If we ignore dependency injection warnings then this gets +1 for RTBC from me.

Thanks @schillerm. Please switch the status to RTBC.

Created #3395316: Use dependency injection.

Coding standards are fixed for 2.0.x in #3359803: Enable testing, add coverage for basic "view" scenario.

Changing status .. sorry I must have missed #6

I have created a merge request with the patch in #4.

Hi, I just tested the new MR!20 with phpcs and i'm getting 0 errors. All good.

With these changes, all checks are passing except cspell and phpstan, which should have their own issues.

Thanks everyone for contributions.
Merged 🍾