When you look at the "Event log" on a test page, it shows all the ins and outs, but doesn't show what the test result was. Would be nice if it shows passed/failed and also a link to the old results.

CommentFileSizeAuthor
#2 pifr_server-add-test-result-to-event-log-1156804-2.patch2.6 KBjthorson
#1 pifr_server-add-test-result-to-event-log-1156804-1.patch2.6 KBjthorson

Comments

jthorson’s picture

jthorson commented
Status: Active » Needs review
StatusFileSize
new pifr_server-add-test-result-to-event-log-1156804-1.patch2.6 KB

I'm pretty sure the old test results get overwritten ... but this patch should add the test result.

jthorson’s picture

jthorson commented
StatusFileSize
new pifr_server-add-test-result-to-event-log-1156804-2.patch2.6 KB

Ooops .. typo referencing the new define constants.

jthorson’s picture

jthorson commented
Status: Needs review » Needs work

Ooops ... patch applies the change at the 'retrieved' stage instead of the 'result' stage, which obviously isn't right.

Unfortunately, the 'pass/fail' status isn't readily available when the actual 'result' state is written to the log, so this becomes less of a 'quick fix' issue.