Tabs Episode 2: Attack of the Clones

This is a re-roll with a missing comma in the install file and missing < in tracker.module.

asimmonds and I were testing and found a few different issues:
- No "my recent posts" tab in tracker
- node/#/edit doesn't work
- admin/content/taxonomy/edit/vocabulary/vid is a 404.

This patch includes asimmond's fix for the forum admin pages, as well as some documentation for the _menu_access function that chx and I worked on.

Does that fix all problems or are there still some open issues? Will this require a second tabs patch?

I'll test this patch ASAP.

One small thing, looking at the patch, the syntax {foo} might be slightly more intuitive than [foo]. No need to change that now, but probably something we'll want to gather some feedback about.

Yes, patched tested and approved.

(subscribing)

This seems like special-case code that needs to be removed. I'd prefer to have a clean and well-definied API rather than one that exploits certain accidentical patterns in the code. Maybe the _load should not be removed, but then we'd still need to unify _from_arg and _load. Having two ways to accomplish something does more harm than good.

+          if (function_exists($matches[1] .'_load')) {
+            $from_arg_functions[$k] = array('function' => $matches[1] .'_load', 'is_numeric' => TRUE);
+            $match = TRUE;
+          }

I don't understand. Can you explain this more/better?

With the anonymous user, I get:
* warning: Invalid argument supplied for foreach() in .\modules\user\user.module on line 57.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: SELECT * FROM users u WHERE in .\includes\database.mysql.inc on line 172.

For the anonymous user, user_current_to_arg() returns a 0, which is not placed into $path_map in _menu_translate() so user_current_load() is then called with a empty string.

Wrapping a isset() around this $return in _menu_translate() seems to fix it for this.

          $return = $to_arg_function(!empty($map[$index]) ? $map[$index] : '');
          if (!empty($map[$index]) || isset($return)) {
            $path_map[$index] = $return;
          }

I can confirm asimmonds's findings. Here's a patch with the isset() added.

The only remaining bug I could find was that profile categories don't seem to show up. To reproduce, enable profile module, add some field, and go to user/1/edit. The tab to edit the field isn't there.

Btw, I tested this pretty thoroughly to thank chx for all the time he spent on the elusive login issue; I enabled all core modules (except menu), hit all URLs with tabs on them, including previous troublespots (tracker, search, forum), so I'm pretty sure once this is fixed, this sucker's ready to go.

Here's above patch without settings.php. :P

Did some more digging... looks like menu_rebuild() isn't being called when profile fields are created, since after putting that in index.php it worked fine. Still investigating.

OK I think this does it. I added a menu_rebuild() right after the cache_clear_all() in profile_field_form_submit.

Marking back for review.

Committah-ed! :)