Closed (fixed)
Project:
D7 Media
Version:
7.x-1.x-dev
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
14 May 2011 at 16:33 UTC
Updated:
25 Nov 2012 at 01:50 UTC
Jump to comment: Most recent file
Comments
Comment #1
mpgeek commented@carole, towards your first point, the media browsing is separate from setting up the input format for media markup, so i think the language is fine. Towards the second point, i would agree the documentation language is a bit confusing. Patch attached.
Comment #3
cachee commentedRecreated patch for 7.x.1.2
Comment #4
devin carlson commentedThanks for the updated patch!
Can you make a patch against Media 2.x (the issue should be solved in 2.x and backported to 1.x)?
Also, I would suggest replacing
<em>Convert Media tags to markup</em>with a%variableplaceholder. See format_string for more information.Comment #5
cachee commentedCreated the patch for 7.x.2.x-dev and inlcuded the suggested change using the %variable function.
Comment #6
cachee commentedThe patch was recreated for 7.x-1.2 to include the suggested changes from comment #4
Comment #7
ParisLiakos commentedthanks commited to 2.x
http://drupalcode.org/project/media.git/commit/74d8686
moving back for 1.x
Comment #8
devin carlson commentedEither patch looks good (they should both work since the same change must be made to Media 1.x as 2.x) but they won't apply.
It looks like the patches were made from the root of a webserver. @cachee can you reroll either patch from inside of the Media repository?
Comment #9
cachee commentedRegenerated the patch for 7.x-1.x-dev using instructions I found at http://drupal.org/node/707484. I also updated an additional line found with the suggested change from comment #4 - This patch has an cut/paste error please to not use.
Comment #10
cachee commentedThe patch from comment #9 has been corrected. Sorry for the earlier error.
Comment #11
ParisLiakos commentedActually
<em>Convert Media tags to markup</em>is not a variable..so it does not need a placeholder1.x commit
http://drupalcode.org/project/media.git/commit/194673c
2.x commit
http://drupalcode.org/project/media.git/commit/f4bbf77
Thanks cachee