On the bottom of the "Edit Workflow" page the roles as well as the allowed transitions per role are completely unordered.

CommentFileSizeAuthor
#3 workflow_permissions.patch2.61 KBpancho
#2 workflow_1.jpg31.21 KBpancho
#1 workflow_0.jpg11.02 KBpancho

Comments

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new workflow_0.jpg11.02 KB

Also, the arrows are not always in line (see attached screenshot).

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
StatusFileSize
new workflow_1.jpg31.21 KB

Sorry, wrong pic...

pancho’s picture

pancho
Location UTC+2 🇪🇺 EU
commented
Title: Ordering on "Edit Workflow" page » Unordered Workflow permissions table
Status: Active » Reviewed & tested by the community
StatusFileSize
new workflow_permissions.patch2.61 KB

Okay, here's a patch for the function workflow_permissions. I completely rewrote the whole function, because it was unnecessarily long and complicated.

I reduced everything to only one database query and one structured array.
The table is now correctly sorted in every respect.
As initially intended by the authors, a header is now also shown for roles that have no permissions.
A missing t() was included for 'author'.

Everything works fine and has been extensively tested by me. As the function is only called on this one page, side-effects are not expected. I therefore set this issue to RTBC.

mfredrickson’s picture

mfredrickson commented
Status: Reviewed & tested by the community » Fixed

Seems like straight-forward stuff. Committed.

Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)