Hello,

I've ported translation_overview module to Drupal 7. Attached patch should resolve all the issues which are referenced to version 7.x of this module. Please verify it and apply on official module source.

You should apply it on current devel version (7.x-2.x-dev, 2011-Feb-25).

This is quite complex patch because I had to make a major refactoring of this module to make it work.

CommentFileSizeAuthor
#7 resolve-remaining-d7-issues-1158294-7-D7.patch46.32 KBwebflo
#6 translation_overview_1158294_6_d7port.patch42.14 KBmiro_dietiker
#5 translation_overview_1158294_5_d7port.patch40.89 KBmiro_dietiker
#3 translation_overview-7.x-2.x-dev-2011-02-25-drupal7-port-v2.patch37.81 KBlklimek
translation_overview-7.x-2.x-dev-2011-02-25-drupal7-port.diff25.24 KBlklimek

Comments

FreeFox’s picture

FreeFox commented
Status: Active » Reviewed & tested by the community

Tested the patch on 3 websites and works great.

Thanks lkklimek

drewish’s picture

drewish commented

just glansed at it and there's some coding standards issues that jumped out at me. you should run coder on it.

lklimek’s picture

lklimek commented
StatusFileSize
new translation_overview-7.x-2.x-dev-2011-02-25-drupal7-port-v2.patch37.81 KB

Hi,

I've used coder (devel version) and corrected all problems, I have also fixed unit tests (translation_overview.test).

Please take a look at attached patch (it's against official 7.x tree). You should apply it on current translation_overview-7.x-2.x-dev.tar.gz.

lklimek’s picture

lklimek commented
Status: Reviewed & tested by the community » Needs review
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new translation_overview_1158294_5_d7port.patch40.89 KB

I have tested the current version and it's completely broken.
We can always improve things in a second step.

I'd prefer to lower the barrier for quick fixes and do quick commits than awaiting for perfect solutions with a completely broken codebase.

After applying the patch the module starts to work. However it took me some time to find the new location of the translation overview table in configuration > content authoring.
http://example.com/admin/config/content/translation_overview_manage
http://example.com/admin/config/content/translation_overview_assignments...

In addition i did some improvements to the patch. Providing update.
Additional code comments, few improved formattings, Cleaner theme function.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
StatusFileSize
new translation_overview_1158294_6_d7port.patch42.14 KB

Providing an additional update after some feedback outside of the queue.

Rechecked and solved all issues of coder (minor).
Additionally identified a conflict and added some fixes for i18n_node and entity_translation. (They all try to override node/%node/translate)

Please review / commit.

webflo’s picture

webflo commented
StatusFileSize
new resolve-remaining-d7-issues-1158294-7-D7.patch46.32 KB

Patch looks basically good. The filter form on 'admin/config/content/translation-overview-manage' was broken, i fixed this and made some other changes.

- Use locale_language_list() instead of language_list() and if ($language->enabled) {}
- Use core strings in translation_overview_node_filters() (see node_filters)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Confirming this works now including the filters.

I think the path of the menu items should be moved to "Content" instead of "Configuration".

At least as a starting point i think the functionality previously covered is back. As a next step we should open the discussion a little wider and think about improved solutions for translation overview, workflows, elements to cover, extensibility and much more.

lklimek’s picture

lklimek commented

Hi,

I've reviewed the patch #7 and it works for me, too.

I'd recommend discussing the path of the menu items in new issue to allow maintainer to commit&close this one ASAP.

drewish’s picture

drewish commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone. I've committed the patch to master and created a new tag so people can test it out.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.