Download & Extend
Drush » Issues

drush dl sends everything to sites/all even though i'm in sites/example.com

Posted by anarcat on May 16, 2011 at 12:29am
Project:Drush
Version:All-versions-5.x-dev
Component:PM (dl, en, up ...)
Category:bug report
Priority:normal
Assigned:jonhattan
Status:closed (fixed)

Issue Summary

So this was fixed for a while, but broke again:

aegir@ceres:~/platforms/pressflow-6.20.97-7.0-staging/sites/example.com/themes$ drush dl genesis
Project genesis (6.x-2.4) downloaded to /srv/aegir/platforms/pressflow-6.20.97-7.0-staging/sites/all/themes/genesis.                                                                         [success]
Project genesis contains 4 themes: genesis_ULTRALITE, genesis_SUBTHEME, genesis_DARK, genesis.
aegir@ceres:~/platforms/pressflow-6.20.97-7.0-staging/sites/example.com/themes$ ls -la
total 8
drwxrwsr-x 2 aegir aegir 4096 mai  2 08:02 .
drwxr-xr-x 7 aegir aegir 4096 mai  2 08:02 ..
aegir@ceres:~/platforms/pressflow-6.20.97-7.0-staging/sites/example.com/themes$
aegir@ceres:~/platforms/pressflow-6.20.97-7.0-staging/sites/example.com/modules/contrib$ drush dl node_gallery_access node_gallery_user_profile node_gallery_taxonomy node_gallery_jcarousel node_gallery_slideshow
Project node_gallery_access (6.x-2.0-beta2) downloaded to /srv/aegir/platforms/pressflow-6.20.97-7.0-staging/sites/all/modules/contrib/node_gallery_access.                                  [success]
Project node_gallery_user_profile (6.x-1.0-beta1) downloaded to /srv/aegir/platforms/pressflow-6.20.97-7.0-staging/sites/all/modules/contrib/node_gallery_user_profile.                      [success]
Project node_gallery_taxonomy (6.x-1.0-beta2) downloaded to /srv/aegir/platforms/pressflow-6.20.97-7.0-staging/sites/all/modules/contrib/node_gallery_taxonomy.                              [success]
Project node_gallery_jcarousel (6.x-1.0-beta2) downloaded to /srv/aegir/platforms/pressflow-6.20.97-7.0-staging/sites/all/modules/contrib/node_gallery_jcarousel.                            [success]
There is no recommended release for project node_gallery_slideshow.
Choose one of the available releases:
[0]  :  Cancel                                                
[1]  :  6.x-1.x-dev  -  2011-Feb-25  -  Supported, Development

1
Project node_gallery_slideshow (6.x-1.x-dev) downloaded to /srv/aegir/platforms/pressflow-6.20.97-7.0-staging/sites/all/modules/contrib/node_gallery_slideshow.                              [success]
aegir@ceres:~/platforms/pressflow-6.20.97-7.0-staging/sites/exmaple.com/modules/contrib$

I suspect this may be related with #1158504: working directory confusion and maybe #1158490: drush dl --destination should assume a relative path, and maybe even #1158474: drush dl doesn't support ACLs although i doubt the latter.

Login or register to post comments

Comments

#1

Posted by anarcat on May 16, 2011 at 12:47am
Status:active» needs review

It *is* relayed to #1158504: working directory confusion - drush_cwd() returns the non-dereferenced path, while the $full_site_root is dereferenced... The attach patch is a workaround, but maybe that just tells us the patch I made for that issue is not complete, as this is still pretty confusing...

AttachmentSize
1158510_dl_wtf.patch 828 bytes

#2

Posted by J0nathan on May 16, 2011 at 12:15pm

Subscribing.

#3

Posted by helmo on December 22, 2011 at 9:22am

I've been having a similar problem. Especially when I use a symlink to get to the site directory.

Aegir provides a set of symlinks in the form of ~/clients/[clientname]/site-uri which links to the site specific directory in whatever platform the site is deployed.

I re-rolled the patch for the current HEAD.

Steps to reproduce:

  1. cd into a site specific directory (e.g. sites/example.com/)
  2. drush dl views
  3. confirm that views is installed in sites/example.com/modules
  4. remove sites/example.com/modules/views
  5. cd /tmp
  6. ln -s /path/to/sites/example.com/ test-symlink-example.com
  7. cd test-symlink-example.com
  8. drush dl views
  9. confirm that views is now installed in sites/all/modules <== The WRONG behavior
  10. remove sites/all/modules/views
  11. apply this path
  12. drush dl views
  13. Views should now be in sites/example.com/modules/views <== As it should be
AttachmentSize
drush-1158510-3-dl_wtf_symlink_realpath.patch 625 bytes

#4

Posted by moshe weitzman on December 31, 2011 at 2:53pm
Assigned to:Anonymous» jonhattan

#5

Posted by moshe weitzman on January 10, 2012 at 5:29am
Status:needs review» fixed

Committed to 5.x

#6

Posted by System Message on January 24, 2012 at 5:30am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.