Active
Project:
MediaFront
Version:
6.x-1.0-rc8
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 May 2011 at 00:40 UTC
Updated:
21 May 2011 at 14:29 UTC
Jump to comment: Most recent file
First off, thanks for all the work on this module.
Just starting to try the RC8 version on part of site that I have been using DashPlayer for some time. The site mainly has MP3 to play, and in DashPlayer the MP3 is an attached file, and a image to show was done with image attach. Setup a preset with just the player and media field so I can get a player when viewing the node. This is something I've wanted for a while, the only problem is that MediaFront doesn't check for image attached images as valid.
I did a quick look at the code and nothing related to images touches image attach. Looking at Dash, the plugin for it seems like it shouldn't be too hard to move over Mediafront.
Also it seems like I have to push the play button twice and I get no total time from the MP3 and the position bar doesn't move. However if I move the bar the playback with then restart from the start. I tried this on both FF4, IE and iPad, same results.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | mediafront_image_attach.tar_.gz | 1.09 KB | jriedel |
| #1 | mediafront_image_attach.tar_.gz | 793 bytes | jriedel |
Comments
Comment #1
jriedel commentedJust played around with the code a bit and made a plugin based on the plugin in Dashplayer and the plugins in Mediafront. I think I have it right. Take a look and can you include it into the build.
Comment #2
travist commentedThank you for the module John.
I certainly will entertain adding this to mediafront, but my only concern with this is just performance. Are you certain that the image_attach or the image module does not give access to these files within the node object on node_load? If not, then I guess this solution will do, but I am wondering if we should implement some caching mechanism since I can easily see this module adding 20+ queries to every page load with a playlist.
Comment #3
jriedel commentedTravis,
Good point on performance. I hang my head in shame since at work I'm one of those guys that ends up fixing performance issues for others. :)
I'm just starting to look at Mediafront to replace Dashplayer on two different sites, and this was one of the first things I saw that needed attention. I would think that Image_attach would have the data in the node load somehow, it displays the image when you look at the full node. I'm not real good at Drupal internals, but as I get time I'll see what I can find to make the process better.
Comment #4
jriedel commentedI made some changes to the plugin and got rid of one of the two selects for each node. Also testing on an iPad I noticed that you might get a very large image. Tweaked the remaining select to smaller of either the preview or original size.
On the other issues of the player not playing, I backed the version to RC7 and now it plays.