By charlie73 on
Hi,
I've created a Drupal 7 module that links the Drupal comments system to our desktop moderation application. I think I've submitted it for review correctly, but could someone just check that submission is ok?
http://drupal.org/node/1145422
Regards,
Charlie.
Comments
Your application looks good.
Your application looks good. I can't grant git access but I'm looking at the code for standards compliance. I'm not on a computer with a server so that's all I can do for now. Here are the issues:
1. Will there be any licensing issues with this? If the included files are not licensed under GPL then you will need to provide instructions on how to get the files because they can't be hosted on d.o.
2. You'll have to remove the LICENSE file as that will be added when the project is created.
3. You have a link to your sandbox, but the sandbox page could use more information if you would like.
4. Maybe your README.txt file could use better instructions on how to actually use the module, but again I'm not able to test it right now and am just doing this as a favor because I saw it!
5. You can remove // $Id$ and ;Id$ from all files we don't use that any more with git.
6. Remove blank lines between doxygen comment and functions, ie:
to
7. There should be a blank * line between the first short line description and longer description in comments, only a few function have this issue:
8. Make sure all comments start with a capital letter and end with a period (.).
9. Comments like:
should be more like
and according to Drupal docs comments should normally start with a verb like "Does this" or "Informs discussit" etc
10. Looks like you wrapped your output code in t() properly.
11. Line 9 in .module is missing a space before the comment.
12. Various blank lines have spaces and there are some tabs throughout the module. White lines should have no spaces and tabs should never be used, only spaces.
Be sure to run it through the coder module (http://drupal.org/project/coder) on (most). I wasn't able to but that will make it much easier to find these issues.
I didn't spend too much time deciphering the code, but I'll have to set the application issue to needs work and refer to this issue until this is completed. Once you've fixed these problems please set it back to needs review.
Thanks for your feedback and time.
I will look into the issues :-)
Looks like a great feature to
Looks like a great feature to have! Nicely done. I'm sure you will do great but those types of coding standards issues are always what is brought up at the start, so you're actually getting a head start now!
Thanks, I've updated the
Thanks, I've updated the module based on your feedback and flagged it for review again.
Thanks again for your help and advice.