I'm looking at various ways to cleanup Storm so that it only contains specialist functionality - and more generic functionality can be outsourced to other Drupal modules.

I think the pdf invoice and send pdf invoice via email functionality could easily utilise the print module. Storm would only have to provide a template.

Comments

paulhudson’s picture

paulhudson commented

Agree,

You know, the invoice module (http://drupal.org/project/invoice) does a really nice job:

has PDF and print support - also already has a nice template for each
create multiple line items through ajax
stores line items temporally in case of browser crash

I'm not familiar with Storm at the moment so not sure how feasible it would be to implement the invoice module as a storm plugin.

I like the look of storm but can see already that I'm going to get really tied of the create invoice page and I don't really want to have to create a template for the print/pdf (nor do I suspect other people will).

Does the above have any traction? I can spend a bit of time on the development.

best, Paul

juliangb’s picture

juliangb commented

See also #1120238: Integrate with Invoice module for a suggestion of integrating with the invoice module.

I am very keen on increasing integration with other modules where appropriate to avoid Storm reinventing the wheel.

paulhudson’s picture

paulhudson commented
Status: Active » Closed (duplicate)

Thanks for the response, I'll continue the tread in your link. :-)

Paul Hudson

juliangb’s picture

juliangb commented
Status: Closed (duplicate) » Active

I'd like to keep this issue open until something is committed to Storm that makes this unnecessary - the reason being that this looks to me to be a quick win simplification for Storm.

juliangb’s picture

juliangb commented
Title: Use Print module for generating pdf invoice » Reimplement pdf invoices using Print module
Project: Storm » Drupal PM (Project Management)
Version: 6.x-2.x-dev » 7.x-1.x-dev
Component: Storm Invoice » Code

I've removed the custom code for generating pdf invoices as part of the port to Drupal 7.

When it goes back, it should be in the form of css for the print module.

undersound3’s picture

undersound3 commented

Perhaps this issue can be closed looking at https://drupal.org/node/2137797?

juliangb’s picture

juliangb commented

Might be, but I don't know at the moment how good the styles are when using print.

As part of this issue, we may be able to implement a specfic print stylesheet that ensured that the invoice comes out neatly.

What are your thoughts, as someone using it in practice?

d34dman’s picture

d34dman commented
Issue summary: View changes
Issue tags: +pm-invoice

Tagging this to collect all invoice related issues.

d34dman’s picture

d34dman commented

Is "storm-initiative-outsourcing" tag still valid?

juliangb’s picture

juliangb commented
Issue tags: -storm-initiative-outsourcing

Nope.

juliangb’s picture

juliangb commented
Status: Active » Closed (won't fix)

We are no longer defining our own invoice content type. The PM Invoice project hooks into other Invoice modules.