Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
node system
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
4 Feb 2007 at 20:02 UTC
Updated:
11 Dec 2007 at 11:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
Bevan commentedI think you misunderstood the documentation -- although, arguable it's not very clear.
Comment #2
Bevan commentedrelated: http://drupal.org/node/180425
Comment #3
catchNeeds a real patch in unified diff format:
http://drupal.org/patch/create
Comment #4
stevenpatzhere's a patch
Comment #5
gpk commentedChanged title to reflect the focus of this issue.
Related questions: is the fact that for PHP input format pages that actually contain PHP code the teaser is always the same as the entire body made clear to the end user? Also that Drupal tries to slice the main body text at a paragraph break to generate the teaser, and that multibyte characters count as multiple characters when calculating the teaser length. These probably belong in new issue(s). [edited]
Comment #6
gpk commentedHmmm not sure there is much actual improvement going on here :/ !!
Comment #7
gpk commentedPrevious patch no longer worked since documentation of node_teaser() had been updated. Here's a new one.
Comment #8
gábor hojtsyIMHO "in a given format" only means that you need to pass on the format (for checking for the PHP format). Otherwise teaser generation is the same in all formats.
Comment #9
gpk commentedAgreed ... I think the point it that "in a given format" does not add anything to "Automatically generate a teaser for a node body" - it only confuses, especially since the argument $format is clearly defined now in the documentation.
Comment #10
gábor hojtsyThanks, committed.
Comment #11
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.