Cascade organic group settings from galleries to images

I think you should reverse the patch and start over.

You have to look at node_gallery_nodeapi()

in case 'insert': for the image type you need to do something similar as in the patch, retrieve the organic group of the gallery and set it for the image. Something like

<?
$gallery_node = node_load($node->gid);
$node->og_groups = $gallery_node->og_groups;
$node->og_groups_both = $gallery_node->og_groups_both;
?>

before the drupal_write_record()

In case 'update': you need something similar as in the original patch as well, updating the group of all images in the gallery if the gallery is updated. This would better be done in batch API though.

In case 'update': you need to add after

    elseif (in_array($node->type, (array)node_gallery_get_types('gallery'))) {
         $old_node = node_load($node->nid);

something like (untested)

     if ($node->og_public != $old_node->og_public || $node->og_groups != $old_node->og_groups ||  $node->og_groups_both != $old_node->og_groups_both) {
    $gid = $node->nid;
    $imagenids = node_gallery_get_image_nids($gid, FALSE, FALSE, TRUE);
    $images = array();
    foreach ($imagenids as $imagenid) {
       $images[] = (object)array('nid' => $imagenid, 'og_public' => $node->og_public, 'og_groups' => $node->og_groups, 'og_groups_both' => $node->og_groups_both);
    }
    $operations[] = array('node_gallery_batch_node_save', array($images));

    if (!empty($operations)) {
      $batch = array(
        'operations' => $operations,
        'finished' => 'node_gallery_image_process_finished',
        'title' => t('Processing Gallery Update.'),
        'init_message' => t('Cascading organic group changes to images.'),
        'progress_message' => t('Processing image updates.'),
        'error_message' => t('Encountered an error while updating images.'),
      );

      batch_set($batch);
    }
     }

Perhaps you can try this patch.

CoreyMoore: Could you perhaps review the patch?

I see. Thank you anyway. Perhaps someone else has an install with OG enabled?

Patch in #7 works for me! Thanks!

You might also want to add a form_alter on the image node form to hide the group settings there. I did it in a custom form stuff module.

I'm looking to integrate NG 3.0-dev into an OG site and am happy to test the patch but after a lot of reading of the issue queue and elsewhere, I have a couple of questions:

I'm looking to allow users to upload personal galleries into their profiles using node_gallery_user_profile. I'd also like group members to be able to upload galleries to groups they are members of. The former would presumably just be posted as 'nodes' and the latter as would presumably be posted as group nodes. so...

1) Should I alter the NG content types to be 'group nodes' or 'standard group posts' or create a new set of NG content types and create a new relationship in the module settings page? Hmmm, I guess that will knacker my plupload integration as it can only be pointed at one field. So, I guess that I can have either group galleries or personal galleries and just use node_gallery_user_profile to display those galleries that users have uploaded to public groups?
2) Is the patch compatible with dev as it looks like it's been written for alpha3

Cheers,
Crom

Following some testing and in response to my own questions - in case anyone else wants to try this:

1) I altered the gallery content type to a standard group post and then controlled the access with the OG audience setting for each gallery that is created. This seems to work fine for both group galleries and personal galleries
2) The patch seems to work fine with the current dev version of NG3

Jaapie,

I also need to hide the group settings on the image node form, and tried to unset($form['og_nodeapi']) without success. Could you share with me the way to hide it in hook_form_alter?

Thanks.

seems $form['og_nodeapi']['#access'] = FALSE do the job.

will this patch be included in the next release of NG, say 6.x-3.0-beta3 ?

Thanks.

Attached patch takes #7 and #15 rolled into one. If you can test this patch and mark this as RTBC, I'll get it into beta3.

An error found:

line # 417, line#19(patch file): if (module_exists('og') {

should be : if (module_exists('og') ) {

Thanks.

Another :

line # 418(node_gallery.module), line#20(patch file): $form['og_nodeapi']['#access'] = FALSE
should be: $form['og_nodeapi']['#access'] = FALSE;

I applied the patch for 6.x-3.0-beta2, after fixing the two lines mentioned above, it works.

Thanks.

Sheesh, that's embarassing. Guess you can tell I did that in a hurry.

I've committed the patch plus your fixes into 6.x-3.x.

:) Thanks a lot!