Counting sessions - sess_count not implemented?

Hello there,

I have applied the following hack to have sess_count functionality.

in the sess_write() function, I have added the following:

    //XXX: Hack to count anonymous users and authenticated users, we use the sessions bin to save these data
    if(!$user->uid) {
      $anonymous_count = dmemcache_get('anonymous_count', 'session');
      $anonymous_count[$user->sid] = $session->timestamp;
      dmemcache_set('anonymous_count', $anonymous_count, 0, 'session');
    }
    else {
      $authenticated_count = dmemcache_get('authenticated_count', 'session');
      $authenticated_count[$user->sid] = $session->timestamp;
      dmemcache_set('authenticated_count', $authenticated_count, 0, 'session');
    }

Then I have coded sess_count like this:

function sess_count($timestamp = 0, $anonymous = true) {
  $cnt = 0;

  if($anonymous) {
    $anonymous_count = dmemcache_get('anonymous_count', 'session');
    foreach($anonymous_count as $sid => $time) {
      if($time > $timestamp) {
        $cnt++;
      }
    }
  }
  else {
    $authenticated_count = dmemcache_get('authenticated_count', 'session');
    foreach($authenticated_count as $sid => $time) {
      if($time > $timestamp) {
        $cnt++;
      }
    }
  }

  return $cnt;
}

Hope this helps.

Great idea, but the problem is: your $anonymous_count and $authenticated_count arrays will grow, and grow, and grow. Right?
I think you need to unset the $sid, so you can just hit count() on the array?

Please look at my patch

Hmm, my previous patch isn't correct. My sess_count() doesn't look to the $timestamp argument. This is the better one