Closed (fixed)
Project:
Comment RSS
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
17 May 2011 at 06:05 UTC
Updated:
31 May 2011 at 15:01 UTC
Jump to comment: Most recent file
howdy!
when crss should be included in a page, it calls drupal_add_feed() in a preprocess_page function.
drupal_add_feed tries to add a feed link to the head of the page, so that feed readers etc. can discover the feed:
<link rel="alternate" type="application/rss+xml" title="localhost - All comments" href="http://localhost/drupal-6/crss" />
however, because $variables['head'] has already been computed at this point, the link is not getting added to head.
the solution to this is to reset $variables['head'] in commentrss_preprocess_page(), and that's what this patch does.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | feed_link_is_not_added_to_head-1159772-1.patch | 592 bytes | firebus |
Comments
Comment #1
firebus commentedif you'd prefer a patch against 7.x-2.x-dev, let me know - i thought i'd hold off since there's no working dev release yet, and maybe the bug doesn't exist in 7?
Comment #2
dave reidFixed in 6.x-2.x: http://drupalcode.org/project/commentrss.git/commit/4887cb4. Confirmed that its not necessary with Drupal 7.