Port the module to D7.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | saving_settings-1159830-4.patch | 5.29 KB | schnitzel |
| #1 | d7port-1159830-1.patch | 10.77 KB | pluess |
Port the module to D7.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | saving_settings-1159830-4.patch | 5.29 KB | schnitzel |
| #1 | d7port-1159830-1.patch | 10.77 KB | pluess |
Comments
Comment #1
pluess commentedThis is a port to D7. Please test and report bugs here.
Comment #2
TomChiverton commentedAwesome work, thank you !
I don't use D7 myself, and see no reason to upgrade for the small use I put Drupal too, so haven't invested the time myself.
I've granted you commit rights (I think) so go ahead and create whatever GIT calls a D7 branch, and we'll put up a beta release ASAP for people to try out (as I can't).
I could do this for you, but I'm not sure if you took the base tag from the 6.x or master branches.
Comment #3
pluess commentedCommitted the patch and crated a 7.x-1.x branch. Please file any issues against this branch.
Comment #4
TomChiverton commentedDev branch published, thanks again !
Comment #5
schnitzel commentedAs discussed with pluess at the drupal usergroup this evening here an extended patch for link_node.
Changelog:
- addapted link_node_filter_link_node_settings() for D7 (no Fieldsets requred, description added)
- Settings in link_node_filter_link_node_settings() are now saved properly (via D7 way to save it)
- in link_node_filter_link_node_process() the settings are also loaded via $filter->settings
- removed echo "hallo" ;)
- theme_link_node_thumbnail($node) changed to theme('link_node_thumbnail', $node);
- link_node_help() adjusted because the "Currently available parameters" cannot be shown (no $filter object)
- link_node_filter_link_node_tips() load settings from $filter->settings
Important!
The Patch is done via "git format-patch"
@Pluess if you apply the patch, can you please use:
this should keep the commiter for my account (what we have discussed) and add your account below.
Happy testing :)
Comment #6
jherencia commentedI prefer not to create a new issue as long as both D7 branch developers are working on this one.
There's a bug when you try to refer in a node's field to itself, the reason is that node_load calls link_node_filter_link_node_process which calls node_load generating an infinite loop.
I've created an issue in style's module refering to the architecture of filters which could let you see a possible situation where administrator's theme theme_link_node_format overwritten function output could be injected in another theme:
#1170736: Better compatibility with media filter (WYSIWYG related)
Thank you for the great work already done.
Comment #7
pluess commentedThanks a lot! Commited the patch.