This field cannot be imported via Feeds.
Is this possible by creating a mapper for it?

CommentFileSizeAuthor
#8 cck_phone_feeds_1160186_7.patch2.25 KBfranz
#7 cck_phone_feeds_1160186_7.patch2.18 KBAnonymous (not verified)
#4 cck_phone_feeds-1160186-4.patch2.69 KBAnonymous (not verified)
#2 cck_phone_feeds-1160186-2.patch2.67 KBAnonymous (not verified)

Comments

ckng’s picture

Status: Active » Postponed

Welcome any patch on this.

Anonymous’s picture

Status: Postponed » Needs review
StatusFileSize
new2.67 KB

Attached is a patch to add feed support to CCK Phone.

ckng’s picture

Status: Needs review » Needs work

I checked #1139676: feeds_alter doesn't support hook_module_implements_alter, hook_hook_info and hook_hook_info_alter is now fixed. Could you reroll and test it on your side?
Don't use feeds importer ATM, so will have to trust you on that, but the code looks fine.

Anonymous’s picture

StatusFileSize
new2.69 KB

Rerolled patch. Have tested in two different install profiles and this patch works well.

Anonymous’s picture

Status: Needs work » Reviewed & tested by the community

Changing to RTBC.

ckng’s picture

Status: Reviewed & tested by the community » Needs work

@kevee
I'm referring to this piece of code

+include_once('cck_phone.feeds.inc'); // To be removed after fixing Feeds issue 1224836, 1139676
+

Do you still need this since #1139676: feeds_alter doesn't support hook_module_implements_alter, hook_hook_info and hook_hook_info_alter is fixed?

Anonymous’s picture

StatusFileSize
new2.18 KB

Sorry, wrong file. Correct, we no longer need that line if the user is on Feed 2.x-dev, but that has not been implemented in a numbered release yet.

franz’s picture

StatusFileSize
new2.25 KB

I think it's useful to add an strtolower() on Country code. In my use case, I use the same country code for and Addressfield, and it requires it to be uppercase, so with this version of the patch, I was able to use the same value on both targets.

Other than that, it works great!

franz’s picture

Status: Needs work » Needs review
jibus’s picture

Hi !

Tested (#8) with an import of 100 phone members. I used country code & phone number in Feeds.

Countries phone tested: Malaysia, France, Italy, Austria, Portugal, Spain, United Kingdom, Germany, Belgium, Mexico, Uruguay, Hong Kong, South Africa, Taiwan, Switzerland, Israel, Brazil, Argentina, Russian Federation, China, Latvia, Netherlands, Croatia, South Korea, Thailand, Colombia, Japan, Greece, Poland, Czech Republic, Slovenia, Indonesia, Romania, Australia, Ghana, Morocco, Lebanon, Serbia, Sweden, India, Denmark, United States, New Zealand, Singapore, Viet Nam, Hungary, Chile and Canada

Worked like a charm, thanks !

jibus’s picture

There is a new "stable" version of feeds 7.x-2.0-alpha5 (2012-May-28), maybe it's time to apply this patch against the 7.x-1.x-dev ?

johnv’s picture

Jibus, this patch is release-independent, as is contains is a new file, with a 'plugin' with a pre-defined interface.

jibus’s picture

@johnv

I don't understand why this feature (which I think is very useful) couldn't be part of the module. Some users who are not very familiar in patching could be interereted.

johnv’s picture

OK, then I misunderstood. I thought you asked for a new version of the patch, but you meant to "commit this patch against the 7.x-1.x-dev of Phone Number ?"
My bad.

jibus’s picture

Yes yes ! Sorry my comment wasn't very clear: my english is not perfect ^^

franz’s picture

Status: Needs review » Reviewed & tested by the community
dddbbb’s picture

So, did this patch get committed to 7.x-1.x-dev or do I still need to patch?

jibus’s picture

Nope, you have to apply this patch against the current dev version if you want to import data into phone number fields

ckng’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Thanks for all the works, committed to D7.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.