I'm attaching a Drupal 7 port patch. I'd appreciate a careful review - this is my first time working on a contrib module.

CommentFileSizeAuthor
#2 xmlcontent.7.x-1.x-dev.tar_.gz5.67 KBDaniel_KM
#1 port_7_patch-1160582.patch12.89 KBbryanesmith

Comments

bryanesmith’s picture

bryanesmith commented
Assigned: bryanesmith » Unassigned
Status: Active » Needs review
StatusFileSize
new port_7_patch-1160582.patch12.89 KB

Note: when applying the patch, first run:

# After running something like: git clone --branch 6.x-1.x http://git.drupal.org/project/xmlcontent.git 
cd xmlcontent
git checkout master
git pull
# Now download the patch  and run: git apply port_7_patch-1160582.patch

Otherwise, the patch will fail.

The patch updates the info file and accounts for many of the API changes in Drupal 7.

The most notable code change is in _xmlcontent_filter_settings. I had to change how settings variables (XSLT, validation and validation file path) are accessed and stored since the admin module pages are different in Drupal 7.

(Essentially, cannot use the input (text) format's name to generate a dynamic, globally-unique variable name in Drupal 7 because settings are set at the same time that an input format is created.)

Daniel_KM’s picture

Daniel_KM commented
StatusFileSize
new xmlcontent.7.x-1.x-dev.tar_.gz5.67 KB

Hi,

Thanks for the patch.

Here is the tarball with the patch already applied.

Sincerely,

Daniel Berthereau
Infodoc & Knowledge management

mgifford’s picture

mgifford
he/him
Primary language English
commented

It's been over a year since the patch was submitted and several months since the tarball was supplied.

Is this module presently being maintained? Is this a good time to be calling for a co-maintainer?