This module overwrites the "system_modules" form submission by using the batch API to build the menu router and links.

It also provides a menu callback and link for building the menu outside the system_modules form.

This is useful when you have a lot of menu callbacks and run out of memory whenever you need to build the menu.

project page: http://drupal.org/sandbox/math3usmartins/1160852

Comments

ralt’s picture

ralt commented
Priority: Normal » Critical

Changing priority according to the new priority guidelines.

davisben’s picture

davisben
Primary language English
Location NH, USA
commented
Priority: Critical » Normal
Status: Needs review » Needs work

I just did a quick review of this module, and it seems to work. However, when disabling the module, I get a WSOD and the following errors in the log.

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE cid = 'schema'' at line 1 query: DELETE FROM WHERE cid = 'schema' in /Users/ben/Sites/d6/includes/cache.inc on line 178.

warning: call_user_func_array() expects parameter 1 to be a valid callback, function 'menu_builder_batch_rebuild' not found or invalid function name in /Users/ben/Sites/d6/includes/menu.inc on line 349.
math3usmartins’s picture

math3usmartins commented
Assigned: Unassigned » math3usmartins
Status: Needs work » Fixed

Please refer to http://drupal.org/node/1166940#comment-5021248

math3usmartins’s picture

math3usmartins commented
Status: Fixed » Needs review
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
  • git release branch missing, see http://drupal.org/node/1015226
  • README.txt missing
  • menu_builder_batch_form_submit_system_modules(): you should clearly document that you copied the function body from system_modules_submit() and describe your customizations.
  • prefix all your functions with your module name to avoid name clashes with others.
  • Maybe shorten the module name to menu_batch?
  • I also think you copied also other large portions of code, please document where they come from and what you had to change.
misc’s picture

misc commented

@mathrm has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

misc’s picture

misc commented
Status: Needs work » Closed (won't fix)

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact