This module is used to periodically pull content from Twitter and generate nodes for your site.

The general intention was for a site to generate weekly Articles based on the output of a single
Twitter feed. However, based on the wide range of options available from the Twitter Pull and Job Scheduler
modules, the configurability of this module was expanded to allow for any time period and any
"twitter_key" (to use the parlance of Twitter Pull).

Additional optional functionality added in configuration was the ability to delete the previously
generated node when the new node is created. This allows for the Twitter article to always be the
most up-to-date news Article at the appropriate time. This feature has the added benefit of
preventing the site from effectively collecting an archive of tweets.

Module dependencies: Twitter Pull, Job Scheduler.

This module can be configured at admin/config/content/twitter_pull_periodic_content.

http://drupal.org/sandbox/dayer4b/1157126

Comments

ralt’s picture

ralt commented
Priority: Normal » Critical

Changing priority according to the new priority guidelines.

jelle_s’s picture

jelle_s
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Needs work

I did a quick Coder review to check the Coding Standards, see below.
I also noticed you have two .info files, one should be removed

A few minor remarks from the coder review:

sites/all/modules/twitter_pull_periodic_content_generator/twitter_pull_periodic_content.module:
 +116: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +120: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
 +126: [minor] in most cases, replace the string function with the drupal_ equivalent string functions

sites/all/modules/twitter_pull_periodic_content_generator/tests/twitter_pull_periodic_content.test:
 +2: [minor] Commits to the Git repository do not require the CVS $Id$ keyword in each file.

I haven't had time to review security etc. yet, but this will at least bump you up to the top of the issue queue again :-)

dayer4b’s picture

dayer4b commented

Jelle_S, thanks for the heads up and bump! I just did a commit with some changes as you requested. Have you had an opportunity to use the module at all?

dayer4b’s picture

dayer4b commented

has anybody tried this module? I'm not sure what the next step is, but I'd like to see if it can be approved.. I'd like to make some contribution to the community.

Everett Zufelt’s picture

Everett Zufelt commented
Priority: Critical » Normal

Took a very quick look.

1. ; $Id: twitter_pull_periodic_content.info
not required in .info file

2. version not required in .info, as this is added by the d.o packager.

3. Test messages are like: $message = t('Function should return no more than 20 tweets'); Generally this should be a success message, like: 'No more than 20 tweets returned'.

4. $node_type = variable_get('twitter_pull_periodic_content_node_type', 'article'); I know that there is a block comment disclaimer 'example', but this is dangerous, as article may not exist.

5. $body_text = t($body_text);You can only translate literal strings with t();
Also $title = t(variable_get('twitter_pull_periodic_content_title', 'This week in tweets'));

Should be:
$title = variable_get('twitter_pull_periodic_content_title', T('This week in tweets')));
And some other non-localized strings.

6. function twitter_pull_periodic_content_menu() {
$items = array();

$items['admin/config/content/twitter_pull_periodic_content'] = array(

Not a big deal at all, but normally paths have - and not _

7. I didn't see any validation of the entries on the settings form, what happens if someone enters 'aa' and not '7' for days interval?

Happy to provide a second glance, please set back to needs review when you're ready.

misc’s picture

misc commented

The applicant has been contacted to ask if the application is abandoned.

misc’s picture

misc commented
Status: Needs work » Closed (won't fix)

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact