Index format_username($account)

Hmm, so $user->name is a unique string, possibly suitable for multi-site faceting, etc.

I'd almost rather add an additional field for the formatted username. I'm also not sure exactly how this would be implemented for a 6.x-3.x backport.

I prefer having an additional field. Calling theme('username') means the themed username will never be stale. (If a user does something to cause their themed name to change, or the themer changes the theme, all format_username's will be stale).

Why is there:

+    $document->uid = $node->uid;

We already have that in $document->is_uid.

Aha. I think creating a fake $account object from scratch is best, like:

$account = (object) array('uid' => $node->uid, 'name' => $node->name);

I agree with James - we don't support a 'uid' field in the schema, use the 'is_uid' that's already indexed.

We already have fixed code to copy fields if needed, like:

function apachesolr_search_node_result($doc, &$result, &$extra) {
  $doc->uid = $doc->is_uid;
  $result += array(
    'type' => node_type_get_name($doc->bundle),
    'user' => theme('username', array('account' => $doc)),
    'date' => isset($doc->changed) ? $doc->changed : 0,
    'node' => $doc,
    'uid' => $doc->is_uid,
  );

  if (isset($doc->is_comment_count)) {
    $extra['comments'] = format_plural($doc->is_comment_count, '1 comment', '@count comments');
  }
}

Looking good, tested and appears to be working well.

New one, bit more readable

Committed

I'm not seeing the patch in #17 in 6.x-3.x-dev. Could it have been inadvertently dropped in a D7 backport?

@scor, understood, but CHANGELOG.txt in 6.x-3.x-dev shows the feature as added FWIW.

In 6.x-3.x it is added as such :

// Index formatted username so it can be searched and sorted on.
  $account = (object) array('uid' => $node->uid, 'name' => $node->name);

  $username = check_plain($account->name);

  $document->ss_name_formatted = $username;

Format_username does not exist in 6.x afaik so closing again