I think it's wrong, that the custom breadcrumb is applied on pages, where nodes are shown only as teasers (pages generated from the views-module for example). I think custom-breadcrumbs should only be visible if a node is shown in fullpage.

Here's a quick-and-dirty fix (change the very first line after the declaration of custom_breadcrumbs_nodeapi:

function custom_breadcrumbs_nodeapi($node, $op, $teaser, $page) {
  if (($op == 'view') && ($teaser == false) && $page) {
    if ($breadcrumb = _custom_breadcrumbs_load_for_type($node->type)) {
    .
    .
    .

But perhaps this hack is not the right solution, either, perhaps we should check, if the user is on a /node/nid-page.

Comments

eaton’s picture

eaton commented

Are you sure you're using the latest version of Custom Breadcrumbs? The 1.1 version of the module specifically includes the check that you added.

eaton’s picture

eaton commented
Status: Active » Needs review

Scratch that, you're right. The change wasn't comitted to the 1.1 release. I've enabled development snapshots for the module -- in a few minutes, a 5.x-1.x dev version should be available on the module's download page. If it fixes the problem for you I'll tag that devel version as an official release. Thanks!

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

IMHO, a breadcrumb should be on every page, showing how you got to where you're at and allowing you to back up through that trail. This includes teaser pages.

eaton’s picture

eaton commented
Status: Needs review » Closed (works as designed)

IMHO, a breadcrumb should be on every page, showing how you got to where you're at and allowing you to back up through that trail. This includes teaser pages.

That may be true, but the module is not capable of doing that using the current Drupal APIs. Teasers are displayed on MANY pages with their own contexts and navigation paths, and taking over those breadcrumbs would break quite a bit of navication.