Is there any reason the theme still loads the marinelli/js/cycle/cycle.js?llen4k file even when the built-in banners are disabled?

Comments

Lioz’s picture

Lioz commented
Status: Active » Needs review

thanks for reporting this

try to replace this function in banners.inc

function marinelli_banners_markup($banners) {
  if ($banners && theme_get_setting('banner_usage') != 0) {
    // Add javascript to manage banners
    marinelli_banners_add_js(count($banners));

    // Generate HTML markup for banners
    return marinelli_banner_markup($banners);
  } else {
    return '';
  }
}
faridjame’s picture

faridjame commented
Status: Needs review » Reviewed & tested by the community

Thanks, works as expected now.

  • Lioz committed 00e53e4 on 7.x-4.x 
    Fixed #1161764: cycle.js loaded only when needed

  • Lioz committed 00e53e4 on 7.x-4.x 
    Fixed #1161764: cycle.js loaded only when needed
oadaeh’s picture

oadaeh commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

This was fixed long ago.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.